remove question truncation since we allow collapsing#311439
Open
meganrogge wants to merge 4 commits intomainfrom
Open
remove question truncation since we allow collapsing#311439meganrogge wants to merge 4 commits intomainfrom
meganrogge wants to merge 4 commits intomainfrom
Conversation
Contributor
Screenshot ChangesBase: Changed (2)
|
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/other/JumpToHint/Dark
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an expand/collapse affordance to the Chat Question Carousel header so long question text isn’t permanently truncated, aligning behavior with other chat confirmation UI.
Changes:
- Introduces an “expand question text” toggle button in the question header actions.
- Implements truncation of long question titles with re-rendering when expanded/collapsed.
- Resets expand state when navigating between questions and updates header action visibility.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatQuestionCarouselPart.ts |
Adds expand/collapse UI + truncation logic for long question titles in the carousel header. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 5
…chatQuestionCarouselPart.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
roblourens
previously approved these changes
Apr 20, 2026
Member
roblourens
left a comment
roblourens
left a comment
There was a problem hiding this comment.
I guess I wonder why we truncate it at all and make me click a button instead of just showing all the content. I definitely need to be able to read it all to answer the question, and 200 characters just isn't very much
Collaborator
Author
|
Now that we have expand/collapse maybe we shouldn't truncate it |
meganrogge
changed the title
roblourens
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #310886 in main
Otherwise, users cannot read the full question.