Address issues

Author: meganrogge

src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatQuestionCarouselPart.ts

@@ -168,13 +168,13 @@ export class ChatQuestionCarouselPart extends Disposable implements IChatContent
 
 		const collapseToggleTitle = localize('chat.questionCarousel.collapseTitle', 'Collapse Questions');
 		const collapseButton = interactiveStore.add(new Button(this._headerActionsContainer, { ...defaultButtonStyles, secondary: true, supportIcons: true }));
-		collapseButton.element.classList.add('chat-question-collapse-toggle');
+		collapseButton.element.classList.add('chat-question-toggle', 'chat-question-collapse-toggle');
 		collapseButton.element.setAttribute('aria-label', collapseToggleTitle);
 		this._collapseButton = collapseButton;
 
 		// Expand button for showing/hiding full question text
 		const expandButton = interactiveStore.add(new Button(this._headerActionsContainer, { ...defaultButtonStyles, secondary: true, supportIcons: true }));
-		expandButton.element.classList.add('chat-question-collapse-toggle');
+		expandButton.element.classList.add('chat-question-toggle', 'chat-question-expand-toggle');
 		this._expandButton = expandButton;
 		this._isQuestionTextExpanded = false;
 		this.updateExpandButton();
@@ -734,19 +734,18 @@ export class ChatQuestionCarouselPart extends Disposable implements IChatContent
 			title.setAttribute('aria-label', messageContent);
 
 			const isLong = messageContent.length > QUESTION_TITLE_TRUNCATION_THRESHOLD;
+			const titleRenderDisposable = questionRenderStore.add(new MutableDisposable());
 			const renderTitle = (expanded: boolean) => {
 				dom.clearNode(title);
 				const plainTextValue = isMarkdownString(questionText) ? renderAsPlaintext(questionText) : questionText;
 				const collapsedValue = isLong
 					? plainTextValue.slice(0, QUESTION_TITLE_TRUNCATION_THRESHOLD).replace(/\s+\S*$/, '') + '…'
 					: plainTextValue;
 				const md = expanded && isMarkdownString(questionText)
-					? new MarkdownString(
-						question.required ? `${questionText.value} *` : questionText.value,
-						{ isTrusted: questionText.isTrusted, supportThemeIcons: questionText.supportThemeIcons }
-					)
+					? MarkdownString.lift({ ...questionText, value: question.required ? `${questionText.value} *` : questionText.value })
 					: new MarkdownString(question.required ? `${collapsedValue} *` : collapsedValue);
-				const rendered = questionRenderStore.add(this._markdownRendererService.render(md));
+				const rendered = this._markdownRendererService.render(md);
+				titleRenderDisposable.value = rendered;
 				title.appendChild(rendered.element);
 			};
 

src/vs/workbench/contrib/chat/browser/widget/chatContentParts/media/chatQuestionCarousel.css

@@ -144,7 +144,7 @@
 			}
 		}
 
-		.monaco-button.chat-question-collapse-toggle {
+		.monaco-button.chat-question-toggle {
 			min-width: 22px;
 			width: 22px;
 			height: 22px;
@@ -155,7 +155,7 @@
 			color: var(--vscode-icon-foreground) !important;
 		}
 
-		.monaco-button.chat-question-collapse-toggle:hover:not(.disabled) {
+		.monaco-button.chat-question-toggle:hover:not(.disabled) {
 			background: var(--vscode-toolbar-hoverBackground) !important;
 		}
 	}