Skip to content

remove question truncation since we allow collapsing #311439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meganrogge wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −6
Open

remove question truncation since we allow collapsing #311439

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
58855be
fixes
meganrogge Apr 20, 2026
0cea2ed
Update src/vs/workbench/contrib/chat/browser/widget/chatContentParts/…
meganrogge Apr 20, 2026
03c9974
Address issues
meganrogge Apr 20, 2026
0c34ebb
better approach
meganrogge Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatQuestionCarouselPart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,13 +687,14 @@ export class ChatQuestionCarouselPart extends Disposable implements IChatContent
const title = dom.$('.chat-question-title');
const messageContent = this.getQuestionText(questionText);
title.setAttribute('aria-label', messageContent);
questionRenderStore.add(this._hoverService.setupDelayedHover(title, { content: messageContent }));

const titleText = question.required
? new MarkdownString(`${isMarkdownString(questionText) ? questionText.value : questionText} *`)
: (isMarkdownString(questionText) ? MarkdownString.lift(questionText) : new MarkdownString(questionText));
const renderedTitle = questionRenderStore.add(this._markdownRendererService.render(titleText));
title.appendChild(renderedTitle.element);
const rawValue = isMarkdownString(questionText) ? questionText.value : questionText;
const suffixed = question.required ? `${rawValue} *` : rawValue;
const md = isMarkdownString(questionText)
? MarkdownString.lift({ ...questionText, value: suffixed })
: new MarkdownString(suffixed);
const rendered = questionRenderStore.add(this._markdownRendererService.render(md));
title.appendChild(rendered.element);
titleRow.appendChild(title);
}

Expand Down
Loading