Repository navigation
fix: resolve cargo-deny advisory failure in tailor - #848
Closed
bfjelds (bfjelds) wants to merge 1 commit into
Closed
bfjelds (bfjelds) wants to merge 1 commit into
bfjelds (bfjelds) wants to merge 1 commit into
Conversation
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
unsafe-libyaml is unmaintained (archived upstream, no safe upgrade available). Pulled in transitively via serde_yaml_ng, which tailor uses for YAML config parsing. No alternative yanks/fixes this release cycle; ignore the advisory until a safe-Rust YAML parser replacement is adopted. Verified: cargo deny check now passes (advisories ok); full tailor test suite unaffected (114 tailor-config + 91 tailor-core + others, 0 failures); clippy clean with no changes needed on main (the two clippy warnings mentioned in earlier CI runs are in signing-support code not yet present on main). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/tailor-ci-fixes
branch
from
October 14, 2026 01:01
3941ec8 to
39dbc27
Compare
bfjelds (bfjelds)
changed the base branch from
user/bfjelds/tailor-fixes
to
main
October 14, 2026 01:02
bfjelds (bfjelds)
marked this pull request as ready for review
October 14, 2026 01:07
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused exception matches Tailor’s locked dependency graph and is clearly justified.
0 open findings
What changed in this PR
Updates Tailor’s dependency policy to acknowledge an unavoidable unmaintained transitive YAML dependency.
Changes:
- Ignores
RUSTSEC-2024-0449with an explanatory rationale.
| File | Description |
|---|---|
tools/tailor/deny.toml |
Adds the targeted advisory exception. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bfjelds (bfjelds)
changed the title
Paco Huelsz (frhuelsz)
approved these changes
Oct 14, 2026
Member
Author
|
replaced with #853 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
tools/tailor's cargo-deny CI failure onmain:RUSTSEC-2024-0449—unsafe-libyamlis unmaintained (archived upstream, no safe upgrade available). Pulled in transitively viaserde_yaml_ng. Added to the advisory ignore list intools/tailor/deny.toml.