Skip to content

fix(gui): restore keep-native-v1 qualifier placement - #7237

Merged
lidge-jun merged 1 commit into
devfrom
codex/fix-models-keep-native-row
Oct 16, 2026
Merged

lidge-jun merged 1 commit into
devfrom
codex/fix-models-keep-native-row

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Oct 16, 2026 •

Copy link
Copy Markdown
Owner

Summary

Verification

  • Per release coordinator instruction, hosted CI is the validation authority. Local test suites and standalone typecheck were NOT RUN; the full repository and GUI regression coverage is left to the PR's hosted Cross-platform CI Linux subset.
  • bun install && (cd gui && bun install && bun run build) — passed, solely to serve the screenshot (the build script includes its normal tsc -b stage).
  • git diff --check — passed.
  • Read all 14 gui/tests files referencing Models.tsx or styles-models-workspace.css; preserve their other source contracts and the auto-review override wiring.
  • Screenshot from the built GUI served by this worktree on port 18770, with fresh temporary OpenCodex and Codex state. Browser layout: 1440px qualifier uses column 2/right edge; at 1100px it uses column 1/start alignment.
  • Hosted CI: pending; exact-head run and job results will be recorded after completion.

Models settings: keep-native qualifier under Sub-agent, with auto-review override preserved

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed. This restores the existing layout contract; no configuration or copy changes.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults. No security-sensitive code changed; temporary screenshot state contains no credentials.

Co-authored-by: sechmachine 97589681+sechmachine727@users.noreply.github.com
Co-authored-by: Jonathan Li 47408717+jonathanli12@users.noreply.github.com

Summary by CodeRabbit

  • Style
    • Updated the layout of the model settings control row, placing its qualifier at the right side on wider screens.
    • On screens narrower than 1160px, the settings use a single-column layout, and the qualifier moves to the start of the row. Its label can wrap when needed.

Restore the keep-native row removed by #7220 while preserving its uniform settings rows and auto-review override. Standard rows span the grid; only the v2 qualifier occupies its right column, with a single-column fallback below 1160px.

Co-authored-by: sechmachine <97589681+sechmachine727@users.noreply.github.com>

Co-authored-by: Jonathan Li <47408717+jonathanli12@users.noreply.github.com>
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner October 16, 2026 09:26
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T09:29:42.970968Z a01329c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added the intake: hygiene-blocked Deterministic PR hygiene checks failed label Oct 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Deterministic hygiene checks failed.

  • missing_regression_test — Behavior changed under src/ or gui/src/ without a test change. Add focused coverage or obtain test-exception-approved.

@github-actions github-actions Bot added the bug Something isn't working label Oct 16, 2026
@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

✅ READY

  • this PR is ready for review.

Hygiene

✅ Deterministic PR hygiene checks passed.

@github-actions
github-actions Bot marked this pull request as draft October 16, 2026 09:27
@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d9aa7971-0302-44d0-8153-744aea7fab7a
📥 Commits

Reviewing files that changed from the base of the PR and between 4ed45e9 and a01329c.

📒 Files selected for processing: 2
  • gui/src/pages/Models.tsx
  • gui/src/styles-models-workspace.css

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📝 Walkthrough

The keep-native setting now uses dedicated row and label containers. The models control top row uses a two-column grid on wider screens and switches to one column below 1160px.

Changes: Models control layout

Layer / File(s) Summary
Keep-native row and responsive layout
gui/src/pages/Models.tsx, gui/src/styles-models-workspace.css
The setting replaces its SettingsRow wrapper with dedicated containers and a separate label; its switch, tooltip, and v2-only condition remain unchanged. The top row uses two columns, and the keep-native qualifier aligns and wraps differently below 1160px.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to a0132

The change restores the keep-native qualifier with responsive placement. No actionable merge risk is established by the supplied context.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: restoring the keep-native-v1 qualifier placement in the GUI.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 2
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lidge-jun

Copy link
Copy Markdown
Owner Author

Maintainer note: this restores markup and CSS that #7220 dropped. The regression coverage already exists. The four keep-native-v1 GUI tests in gates fail on dev 4ed45e9 (Cross-platform run 38879287332) and pass on this head. Applying test-exception-approved because no new test is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working test-exception-approved Maintainer approved a non-automated regression-test exception

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant