Initialize viewport state before missing lookup handling - #792
Open
sylvesterkaczmarek wants to merge 2 commits into
Open
Initialize viewport state before missing lookup handling#792sylvesterkaczmarek wants to merge 2 commits into
sylvesterkaczmarek wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the missing-viewport path in
IsaacGetViewportRenderProduct.OgnIsaacGetViewportRenderProductInternalState.__init__()currently assignsviewport = Noneto a local variable instead ofself.viewport. Ifget_viewport_from_window_name()cannot resolve the requested viewport on the first compute, the node then evaluatesdb.per_instance_state.viewport is Nonebefore that attribute exists and can raiseAttributeErrorinstead of following its documented warning/Falsepath.Initialize the instance cache correctly with
self.viewport = None. Also make the existing warning interpolate the requested viewport name instead of logging the literal{db.inputs.viewport}text.Validation
compute()returnsFalserather than raisingNoneand the node is marked uninitialized