Skip to content

Refresh HolonomicController when wheel geometry changes - #790

Open
sylvesterkaczmarek wants to merge 4 commits into
isaac-sim:developfrom
sylvesterkaczmarek:fix/holonomic-controller-input-refresh
Open

Refresh HolonomicController when wheel geometry changes#790
sylvesterkaczmarek wants to merge 4 commits into
isaac-sim:developfrom
sylvesterkaczmarek:fix/holonomic-controller-input-refresh

Conversation

@sylvesterkaczmarek

Copy link
Copy Markdown

Description

Make HolonomicController refresh its cached controller when wheel geometry inputs change at runtime.

The node currently copies wheelRadius, wheelPositions, wheelOrientations, mecanumAngles, wheelAxis, and upAxis only during its first initialization. This means a graph that retargets HolonomicRobotUsdSetup to another robot can supply new wheel geometry while HolonomicController continues computing commands with the previous robot's geometry.

When an initialized node detects a change in any wheel-geometry input, mark the cached controller uninitialized and reuse the existing validation/initialization path to rebuild it. Steady-state behavior is unchanged when geometry inputs are stable.

Validation

  • regression test evaluates the controller with 0.04 m wheel radii
  • doubles all wheel radii to 0.08 m without resetting the graph
  • verifies the next evaluation immediately uses the new geometry and halves the required wheel angular velocities
  • existing initialization and validation path is reused unchanged
  • production diff is ten lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant