Honor articulation controller retargeting and joint index zero - #787
Open
sylvesterkaczmarek wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix two input-refresh bugs in
IsaacArticulationController.First, the controller resolves
robotPath/targetPrimonly during initialisation. If the robot target changes later, the cachedArticulationremains bound to the previous robot and subsequent commands are applied to the wrong articulation.Second, explicit joint-index selection uses
np.asarray(joint_indices).any()to decide whether an index list is present. ForjointIndices=[0],.any()is false, so DOF 0 is treated as if no explicit index were supplied and the controller can fall through to the all-DOFs path.This change resolves the requested robot on each compute and rebuilds the controller when it changes. It also tests index-list presence by size rather than value, so zero is a valid explicit DOF index.
Validation
jointIndices=[0]applies a one-value command specifically to DOF 0/RobotAto/RobotBreinitializes the articulation controller