Reinitialize holonomic robot setup when prim paths change - #784
Open
sylvesterkaczmarek wants to merge 2 commits into
Open
Reinitialize holonomic robot setup when prim paths change#784sylvesterkaczmarek wants to merge 2 commits into
sylvesterkaczmarek wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make
HolonomicRobotUsdSetuprefresh its cached robot parameters whenrobotPrimorcomPrimis retargeted.The node already detects path changes and updates the stored strings, but it leaves
state.initializedset and retains the previousHolonomicRobotUsdSetupobject. The existing initialization guard then skips rebuilding the setup and the node continues publishing wheel parameters from the old robot.Clear the cached parameter object and mark the state uninitialized whenever either prim path changes. The normal initialization path then rebuilds parameters for the new target.
Validation
HolonomicRobotUsdSetupis constructed for both targets