Reset Hydra texture state when render product changes - #782
Open
sylvesterkaczmarek wants to merge 2 commits into
Open
Reset Hydra texture state when render product changes#782sylvesterkaczmarek wants to merge 2 commits into
sylvesterkaczmarek wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make
IsaacAttachHydraTexturecorrectly follow changes toinputs:renderProductPrim.The node caches both its Hydra texture and the set of render vars it has already applied. Previously that cache was not associated with a render-product path, so changing the target could leave the existing texture bound to the previous render product while render vars were incorrectly treated as already applied.
Track the current render-product path in the internal state. When the target changes, disable and release the cached texture, clear the applied render-var cache and timeline subscriptions, and let the normal compute path create a fresh attachment for the new target. Re-evaluating the same target keeps the existing cached state.
Validation
OgnIsaacAttachHydraTexture.py