Fix physics sensor create return type annotation - #777
Open
sylvesterkaczmarek wants to merge 4 commits into
Open
Fix physics sensor create return type annotation#777sylvesterkaczmarek wants to merge 4 commits into
sylvesterkaczmarek wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the static return type of physics sensor authoring factories, including
IMU.create()._PhysicsSensorAuthoring.create()constructscls(...), but its return annotation names the private_PhysicsSensorAuthoringbase class. Static type checkers therefore infer calls such asIMU.create(...)as the base type even though the runtime object is anIMU.Use
typing.Selffor the shared classmethod return type. This preserves the existing implementation and runtime behavior while allowing type checkers to infer the concrete subclass correctly for IMU and the other physics sensor authoring classes.Validation
return cls(...)implementationFixes #771.