Fix IMU linear acceleration frame differentiation - #769
Open
sylvesterkaczmarek wants to merge 4 commits into
Open
Fix IMU linear acceleration frame differentiation#769sylvesterkaczmarek wants to merge 4 commits into
sylvesterkaczmarek wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix IMU linear acceleration for rigid bodies that rotate while translating.
Both the current experimental implementation and the deprecated IMU implementation rotated world-frame linear velocity into the sensor frame before finite differencing it. Because the sensor frame changes while the body rotates, differencing those rotating-frame components produces incorrect apparent acceleration.
The fix keeps linear velocity in the inertial world frame through the finite-difference/filter step, then rotates the resulting acceleration into the current sensor frame. Angular velocity and orientation handling are unchanged.
This PR addresses only the confirmed differentiation-frame bug from #735; the separate COM/lever-arm enhancement mentioned there is out of scope.
Validation
py_compilegit diff --checkFixes #735.