Repository navigation
fix(ci): approve the brand image hashes in the privacy scan - #1
Merged
Merged
Conversation
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by mau
Before: CI on
mainhas failed since the brand images landed. The privacy scan rejectsdocs/assets/impossible-inference-scene.png(andsocial-preview.png) as unexpected binary content because only the header image's hash was approved. Every PR inherits the red build.After: both images are on the approved-binary list with their exact SHA-256 hashes, so the privacy scan passes and later steps (foundation snapshot, line endings, third-party notices, packaging, container) run again.
How: two entries added to
$approvedBinaryHashesinscripts/privacy-scan.ps1. Any later change to either image still fails the scan until its hash is reviewed.