Repository navigation
fix(serve): shut down gracefully on SIGTERM - #3
Merged
Merged
Conversation
autoantohaki
force-pushed
the
fix/serve-sigterm
branch
from
October 22, 2026 01:28
9da10c7 to
e78aa77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by mau
Before:
serveonly listened for Ctrl+C.docker stop,kill, and service managers send SIGTERM, which skipped the graceful drain entirely. In the container the server runs as PID 1, where an unhandled SIGTERM is ignored, sodocker stophung for its full grace period and then SIGKILLed the process, abandoning in-flight requests and leaving the llama.cpp child to be killed without the bounded shutdown path.After: on Unix, SIGTERM triggers the same bounded shutdown as Ctrl+C: HTTP and gRPC admission stops, in-flight work drains within
--shutdown-timeout-ms, the private runtime is terminated, and the process exits 0.How: a small
shutdown_requested()helper inmain.rswaits for either Ctrl+C or SIGTERM (Unix only; Windows keeps Ctrl+C). A new Unix-only binary test starts the real server, sendskill -TERM, and asserts a clean exit. The README container section mentions the behavior.CI needs #1 merged first (it restores the privacy-scan and supply-chain checks on
main).