Repository navigation
fix(grpc): default each unset sampling field independently - #2
Merged
Merged
Conversation
autoantohaki
force-pushed
the
fix/grpc-partial-sampling
branch
from
October 22, 2026 01:27
b50e70c to
6a948d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by mau
Before: a gRPC request that set only some
Samplingfields was rejected. With proto3 scalars, an unsettop_parrives as0and an unsetmax_tokensas0, so{"sampling":{"maxTokens":32}}failed withINVALID_ARGUMENT: top_p must be greater than 0, and{"sampling":{"seed":7}}failed onmax_tokens. Only "no sampling at all" or "every field set" worked.After: each unset field falls back to the same default HTTP uses (
max_tokens256,temperature0.8,top_p0.95), so callers can set just what they need. An explicittemperature: 0still means greedy decoding.How:
max_tokens,temperature, andtop_pare now proto3optional(wire-compatible: existing clients that send values are unaffected), andsampling()ingrpc.rsdefaults each field independently. A unit test covers partial, greedy, and absent sampling; the gRPC API doc notes the defaults.CI needs #1 merged first (it restores the privacy-scan and supply-chain checks on
main).