Repository navigation
fix(frontend): the #124 bumps broke the build -- useRef under React 19 types, manualChunks under vite 8 - #140
Merged
hyperpolymath merged 1 commit intoOct 15, 2026
Conversation
…9 types, manualChunks under vite 8 #124 bumped React to 19.3 and vite to 8.3 together, and with nothing requiring the checks, it merged with the frontend build already red. Two breaks, both real: - React 19's types dropped the zero-argument useRef overload, so TreeView's two timer refs (saveTimer, scrollTimer) no longer compiled: TS2554, twice. They now take the explicit undefined they always had at runtime. - vite 8's rolldown core accepts only the function form of manualChunks; the object form in vite.config.ts died at "manualChunks is not a function". The function keeps the same chunking -- plotly still lands in its own 4.6 MB chunk. tsc and the full bun test suite pass (42/42); vite build completes in under 3s with the same chunk layout as before the bumps. Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 25 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This was referenced Oct 15, 2026
hyperpolymath
deleted the
arena/35638cac-dd6c-4e06-b0f0-f5e9292c1581-metamanifold-webui
branch
October 15, 2026 02:45
Owner
Author
|
@coderabbitai review |
|
hyperpolymath
added a commit
that referenced
this pull request
Oct 15, 2026
…PR (#141) ## What this changes #124 grouped every frontend update, and with nothing requiring the checks it merged five framework majors -- React 18->19, vite 6->8, TypeScript 5->7, react-router-dom 6->7, plotly 2->4 -- in one PR, with `tsc` already red until #140 repaired it. A major is a migration, not an update: it must carry its own review and its own CI run. Both update groups (`frontend`, `github-actions` -- checkout v4.4.0 -> v7.0.1 came through #123 the same way) now name `update-types: ["minor", "patch"]` only. A Dependabot update matching no group opens its own PR, so majors arrive one at a time; minor and patch still batch weekly as before, so the noise stays low. A new testset in `test/unit/test_install_pins.jl` pins the shape -- both ecosystems declared, the frontend on `bun`, and no group whose `update-types` admit `major` -- so a future group cannot silently go back to batching majors. This is the same defence-in-depth the file already applies to workflow pins: the config asserts the policy, and the policy is enforced at the door. ## How to run its tests From the repository root: ``` julia --project=. test/unit/test_install_pins.jl ``` All testsets pass locally (223 prior assertions plus the new 9). ## What this leaves out No `open-pull-requests-limit` or other throttles: with majors unbatched the default limit of 5 per ecosystem keeps the queue bounded, and the first runs under this config (#123/#124) showed the volume is small. No change to security updates, which follow their own path. ## Versions tested Julia 1.13.1 locally (CI pins 1.12.5). No other tool touched. Note: the commit is unsigned (the signing key's passphrase is unavailable to the session); amend to sign if required. --------- Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai> Co-authored-by: Mistral Vibe <vibe@mistral.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
#124 (Dependabot's frontend group) bumped React 18 -> 19.3, vite 6 -> 8.3, TypeScript 5.7 -> 7, react-router-dom 6 -> 7 and plotly 2 -> 4 in one merge, and -- with no required checks yet -- it landed with
tscalready failing. Main cannot build its frontend right now; this PR is that repair, two real breaks:useRefoverload.TreeView.tsx's two timer refs (saveTimer,scrollTimer) failedtscwith TS2554 twice. They now pass the explicitundefinedthey always had at runtime:useRef<number | undefined>(undefined).manualChunks. The object form invite.config.tsdied atmanualChunks is not a function. The function keeps the same chunking -- plotly still lands in its own 4.6 MB chunk.How to run its tests
From
frontend/:Verified locally on this exact tree.
What this leaves out
React 19, react-router 7, TypeScript 7 and plotly 4 are runtime majors that type-check and build clean but deserve their own smoke test of the running app; this PR only restores what the bumps broke mechanically. If the majors prove too hot, the alternative is re-pinning them in
package.json-- but that is a decision about keeping #124, not about fixing it.Versions tested
bun 1.4.3 (local mise shim; CI installs the
tool_versions.ymlpin). Julia, R and Agda untouched.Note: the commit is unsigned (the signing key's passphrase is unavailable to the session); amend to sign if required.
Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe vibe@mistral.ai