Repository navigation
fix(frontend): adapt to the Dependabot group bump (typescript 7, vite 8, @types/react 19) - #142
hyperpolymath wants to merge 1 commit into
Conversation
… 8, @types/react 19) PR #124's frontend group bump broke the build on main in two places; both are adaptor fixes, no behaviour change: - @types/react 19 removed useRef's no-argument overload, so TreeView's two timeout refs now take an explicit undefined initial value: useRef<number | undefined>(undefined). - Vite 8 (rolldown) accepts manualChunks only as a function; vite.config.ts now routes plotly.js-dist-min to the 'plotly' chunk functionally, which emits the same separate 4.6 MB chunk as the object form did. Verified: bun run typecheck clean, 42/42 tests pass, bun run build succeeds and still emits assets/plotly-*.js as its own chunk. This also unblocks PR #125, whose Julia-tests job builds the frontend and inherited main's breakage. Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 19 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Closing as a duplicate of #140: both fix the same two #124 breaks (React 19's zero-argument useRef overload in TreeView.tsx, and vite 8's function-only manualChunks in vite.config.ts) with functionally identical changes -- verified line-by-line; the only differences are comments and formatting. Keeping #140, which was opened first, carries the fuller root-cause description, and already has CodeQL/SonarCloud/semgrep green with Julia tests running. |



What this changes
PR #124 (the Dependabot frontend group bump) landed with a build that no longer compiles, so main is currently red for anything that builds the frontend — including #125's Julia-tests job, which inherited the failure. Two adaptor fixes, no behaviour change:
TreeView.tsx—@types/react@19.3removeduseRef's no-argument overload, so the two timer refs (saveTimer,scrollTimer) now take an explicituseRef<number | undefined>(undefined).vite.config.ts— Vite 8 (rolldown) acceptsmanualChunksonly as a function. The object form{ plotly: ['plotly.js-dist-min'] }is now the equivalent function form; the build still emitsassets/plotly-*.jsas its own 4.6 MB chunk, exactly as before.Verification
bun run typecheck— clean (this was failing:TS2554: Expected 1 arguments, but got 0at TreeView.tsx:186,231)bun run test— 42/42 passbun run build— succeeds; plotly chunk emitted separately as beforeHow to run the tests
Notes
Julia testscheck (which builds the frontend) is green.Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe vibe@mistral.ai