Skip to content

fix(frontend): adapt to the Dependabot group bump (typescript 7, vite 8, @types/react 19) - #142

Closed
hyperpolymath wants to merge 1 commit into
mainfrom
fix/treeview-useref-react19
Closed

hyperpolymath wants to merge 1 commit into
mainfrom
fix/treeview-useref-react19

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

What this changes

PR #124 (the Dependabot frontend group bump) landed with a build that no longer compiles, so main is currently red for anything that builds the frontend — including #125's Julia-tests job, which inherited the failure. Two adaptor fixes, no behaviour change:

  1. TreeView.tsx — @types/react@19.3 removed useRef's no-argument overload, so the two timer refs (saveTimer, scrollTimer) now take an explicit useRef<number | undefined>(undefined).
  2. vite.config.ts — Vite 8 (rolldown) accepts manualChunks only as a function. The object form { plotly: ['plotly.js-dist-min'] } is now the equivalent function form; the build still emits assets/plotly-*.js as its own 4.6 MB chunk, exactly as before.

Verification

  • bun run typecheck — clean (this was failing: TS2554: Expected 1 arguments, but got 0 at TreeView.tsx:186,231)
  • bun run test — 42/42 pass
  • bun run build — succeeds; plotly chunk emitted separately as before
  • No lockfile or manifest change; dependency versions stay exactly as chore(deps): bump the frontend group in /frontend with 10 updates #124 pinned them

How to run the tests

cd frontend && bun run typecheck && bun run test && bun run build

Notes

  • Root cause context: chore(deps): bump the frontend group in /frontend with 10 updates #124's own CI had not completed when it was merged; this is the repair. Going forward the Dependabot PRs should be held until their Julia tests check (which builds the frontend) is green.
  • The commit is unsigned — the signing key's passphrase was not available in the session that produced it.

Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe vibe@mistral.ai

… 8, @types/react 19)

PR #124's frontend group bump broke the build on main in two places; both
are adaptor fixes, no behaviour change:

- @types/react 19 removed useRef's no-argument overload, so TreeView's
  two timeout refs now take an explicit undefined initial value:
  useRef<number | undefined>(undefined).
- Vite 8 (rolldown) accepts manualChunks only as a function; vite.config.ts
  now routes plotly.js-dist-min to the 'plotly' chunk functionally, which
  emits the same separate 4.6 MB chunk as the object form did.

Verified: bun run typecheck clean, 42/42 tests pass, bun run build
succeeds and still emits assets/plotly-*.js as its own chunk. This also
unblocks PR #125, whose Julia-tests job builds the frontend and inherited
main's breakage.

Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 19 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 0bcac6b5-4a3a-4ca7-84ac-ace7d4bbf4ab
📥 Commits

Reviewing files that changed from the base of the PR and between 15a6b5d and f1cd42c.

📒 Files selected for processing: 2
  • frontend/src/views/TreeView.tsx
  • frontend/vite.config.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath

Copy link
Copy Markdown
Owner Author

Closing as a duplicate of #140: both fix the same two #124 breaks (React 19's zero-argument useRef overload in TreeView.tsx, and vite 8's function-only manualChunks in vite.config.ts) with functionally identical changes -- verified line-by-line; the only differences are comments and formatting. Keeping #140, which was opened first, carries the fuller root-cause description, and already has CodeQL/SonarCloud/semgrep green with Julia tests running.

@hyperpolymath
hyperpolymath deleted the fix/treeview-useref-react19 branch October 15, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant