Skip to content

Fix build_c: ARCH test compares a literal, and CFLAGS is empty for both shared libraries #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
richard-burhans wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix build_c: ARCH test compares a literal, and CFLAGS is empty for both shared libraries #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,16 @@ build: chmod install check build_c build_cesar build_cython build_rust train_mod

install: install_binaries install_python install_third_party install_postoga

TOGA_CFLAGS = -Wall -Wextra -O2 -g -std=c99
ifeq ($(ARCH),arm64)
TOGA_CFLAGS += -arch arm64
endif

build_c:
if [ ARCH = "arm64" ]; then \
CFLAGS="-Wall -Wextra -O2 -g -std=c99 -arch arm64"; \
else \
CFLAGS="-Wall -Wextra -O2 -g -std=c99"; \
fi; \
mkdir -p bin && gcc $$CFLAGS -o bin/chain_filter_by_id src/c/chain_filter_by_id.c
gcc $$CFLAGS -fPIC -shared -o src/python/modules/chain_coords_converter_slib.so src/c/chain_coords_converter_slib.c
gcc $$CFLAGS -fPIC -shared -o src/python/modules/chain_bst_lib.so src/c/chain_bst_lib.c
mkdir -p bin
gcc $(TOGA_CFLAGS) -o bin/chain_filter_by_id src/c/chain_filter_by_id.c
gcc $(TOGA_CFLAGS) -fPIC -shared -o src/python/modules/chain_coords_converter_slib.so src/c/chain_coords_converter_slib.c
gcc $(TOGA_CFLAGS) -fPIC -shared -o src/python/modules/chain_bst_lib.so src/c/chain_bst_lib.c
echo ${DELIM}

build_cesar:
Expand Down