Skip to content

Fix check_shell: $(echo $0) is expanded by make, not the shell #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
richard-burhans wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix check_shell: $(echo $0) is expanded by make, not the shell #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## TOGA2 supports bash only; make's default recipe shell is /bin/sh, which is dash on
## Debian/Ubuntu. Set it explicitly so recipes and check_shell agree.
SHELL := /bin/bash

ARCH=$(shell uname -m)
CHECK_DEPS=check_dependencies.py
DELIM="=============================="
Expand Down Expand Up @@ -53,10 +57,11 @@ check_python:
python3 ${CHECK_DEPS} python --installation_mode

check_shell:
if [ $(echo $0) != "-bash" ]; then \
echo "ERROR: TOGA2 currently only supports bash as operating shell. Please change you default shell or create a separate environment with bash as default"; \
@if [ -n "$${BASH_VERSION:-}" ]; then \
echo "bash detected ($$BASH_VERSION); shell type check successfully passed"; \
else \
echo "bash has been found to be a default current shell; shell type check successfully passed" ; \
echo "ERROR: TOGA2 currently only supports bash as operating shell. Please change your default shell or create a separate environment with bash as default" >&2; \
exit 1; \
fi

check_third_party:
Expand Down