Skip to content

Add plugin row actions and detail tabs; fix disable navigation and mobile sidebar access - #2916

Merged
brsbl merged 13 commits into
mainfrom
bb/plugin-row-actions-v1-thr_ccffp4w2p2
Sep 11, 2026
Merged

Add plugin row actions and detail tabs; fix disable navigation and mobile sidebar access#2916
brsbl merged 13 commits into
mainfrom
bb/plugin-row-actions-v1-thr_ccffp4w2p2

Conversation

@brsbl

@brsbl brsbl commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Human comments

What was wrong

  • Plugin row menus lacked detail and disable actions, while mobile offered an unsupported split action.
  • View details left the current workspace. Disabling an open plugin briefly showed an unavailable panel and left stale navigation history.
  • Full-screen mobile panels covered the left sidebar control.

What changed

  • Shares the same dropdown and right-click actions: Open in split when supported, View details, Hide from sidebar, separator, Disable. Mobile omits splitting. Hide from sidebar keeps its existing label, eye-off icon, and visibility-only behavior; direct plugin launch is unchanged.
  • Opens or focuses details in the current new-thread, thread, or plugin workspace. Close panel tab / Cmd+W closes visible details without terminating the underlying terminal. Detail tabs support reordering alongside existing tabs.
  • Keeps early detail requests in their original pane while it loads; discards pending requests when that workspace is replaced.
  • Removes only the disabled plugin’s panes before unloading it. Other splits stay open; the last pane becomes New thread. Replaces the active history entry and refreshes installed-plugin state.
  • Keeps mobile sidebar access reachable on Plugins, plugin details and workspaces, Settings, and Skills. Uses existing menu and panel primitives; no public SDK, protocol, or persisted-data changes.

How you verified

  • Post-merge CI is resolved: all 13 jobs passed on 9882e4a79, including Linux FUSE/AppImage checks.
Post-merge CI failure and resolution

The original merge run on 22c3fc0e8261e84f275c4a16c4f9b9bc9a47b150 passed 12 jobs but timed out twice in the shared Ubuntu FUSE-install step. The preceding main run had the same failure.

The shared workflow fix in #3486, 9882e4a79cbb7f354d73f9cc2e96a700c33f08fb, pins a reachable HTTPS Ubuntu mirror and skips optional DEP-11 metadata. That main revision includes this PR. Its remote CI passed all 13 jobs: FUSE installation completed in six seconds, followed by successful AppImage packaging and mount-lifecycle smoke. Version Lockstep also passed. No additional plugin changes were needed.

  • Remote CI is green for 33b2a2b1dda5b0761bdcdbf91933900d6a73307e: all six test shards, build/typecheck/lint, bundle checks, Linux/macOS package smoke on Node 22, and PR guards passed. Node compatibility and mobile E2E were skipped by workflow conditions. No CI-equivalent checks ran locally.
  • Regression coverage protects menu parity and compact split omission, hide-versus-disable behavior, disable/history/split preservation, terminal-safe detail closure, tab ordering, loading-time pane ownership, and mobile sidebar controls. The close, reorder, and early-open regressions failed remotely before their fixes.
  • User QA passed the broader flows and restored Hide from sidebar menu on 1e95783ec59d583af9d45694f798d435902d1e46; browser/version/viewport were not recorded.
  • Exact-head targeted browser QA passed on native Apple Silicon Chrome for Testing 153.0.8010.36 against 33b2a2b1dda5b0761bdcdbf91933900d6a73307e, light theme, desktop 1440×900 and mobile 390×844 with touch, scale 1. Verified the row menus, detail tabs retaining the current workspace, mobile sidebar access, Cmd+W preserving a running underlying terminal, mixed detail-tab reordering, and a detail request made while the plugin workspace module was deliberately held pending. Reused prior valid QA for unchanged disable/split flows. The only browser console message during these checks was the existing Jotai loadable deprecation warning.
  • Captured and visually inspected six matched before/after pairs and two additional final-head detail-tab views in the same isolated source-app checkout. Attachments are hosted directly in get-bb/bb, outside product-code commits.

Screenshots

  • Before: merge base fa1f44ebe9e5676004b669e48c99b3c7606466b6. After: exact head 33b2a2b1dda5b0761bdcdbf91933900d6a73307e.
  • All captures use the branch web app in native Chrome for Testing 153.0.8010.36, light theme, scale 1, and the same isolated synthetic data with first-party Plugin Guide and Automations enabled. Each pair matches route, fixture, interaction, and viewport. Desktop is 1440×900; mobile is 390×844 with touch.
  • Row menus: /, Plugin Guide options open; open the sidebar first on mobile. Plugin details: direct /plugins/plugin-api-docs, settled first carousel slide, sidebar closed.
  • Retained mobile access: /settings on General, /skills on Browse, and /plugins/automations/automations on Installed with zero automations; each at the top with sidebar closed.
Flow / viewport Before — merge base After — final head
Row menu — desktop 1440×900 Before: desktop plugin row menu After: desktop row actions including View details, Hide from sidebar, and Disable
Row menu — mobile 390×844 Before: mobile plugin row menu After: mobile row actions omit splitting
Plugin details — mobile 390×844 Before: details covers the left sidebar control After: left sidebar control remains reachable on details
Settings — mobile 390×844 Before: Settings sidebar control After: Settings sidebar access retained
Skills — mobile 390×844 Before: Skills sidebar control After: Skills sidebar access retained
Plugin workspace — mobile 390×844 Before: Automations workspace sidebar control After: plugin workspace sidebar access retained
  • Additional final-head flow: start at /, open Plugin Guide options, select View details, and dismiss the mobile drawer. Details remain in a tab while the new-thread workspace and route are preserved. These are after-only views because the merge-base row menu has no View details action.
After — web/desktop 1440×900 After — mobile 390×844
After: Plugin Guide detail tab preserves the new-thread workspace After: mobile detail tab remains open in the current workspace

BB-Thread-ID: thr_ccffp4w2p2

AGENT GENERATED

@brsbl brsbl changed the title Focus plugin row actions Remove sidebar-position controls from plugin row menus Sep 2, 2026
@brsbl
brsbl changed the base branch from bb/customizable-sidebar-navigation-v1-thr_ccffp4w2p2 to bb/customize-sidebar-navigation-v2-thr_ccffp4w2p2 September 3, 2026 01:32
Base automatically changed from bb/customize-sidebar-navigation-v2-thr_ccffp4w2p2 to main September 3, 2026 06:25
@brsbl brsbl changed the title Remove sidebar-position controls from plugin row menus Unify plugin row menu actions Sep 10, 2026
@brsbl
brsbl force-pushed the bb/plugin-row-actions-v1-thr_ccffp4w2p2 branch 2 times, most recently from 9ff3761 to 5a95378 Compare September 10, 2026 21:08
@brsbl brsbl changed the title Unify plugin row menu actions Keep plugin navigation in the current workspace Sep 11, 2026
@brsbl
brsbl removed this pull request from stack #2980 September 11, 2026 04:55
@brsbl
brsbl force-pushed the bb/plugin-row-actions-v1-thr_ccffp4w2p2 branch from aedd741 to 5518ef8 Compare September 11, 2026 14:58
@brsbl brsbl changed the title Keep plugin navigation in the current workspace Keep plugin details and actions in the current workspace Sep 11, 2026
@brsbl brsbl changed the title Keep plugin details and actions in the current workspace Add plugin row actions and detail tabs; fix disable navigation and mobile sidebar access Sep 11, 2026
@brsbl
brsbl merged commit 22c3fc0 into main Sep 11, 2026
16 checks passed
@brsbl
brsbl deleted the bb/plugin-row-actions-v1-thr_ccffp4w2p2 branch September 11, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant