Skip to content

Open plugin details without leaving the workspace - #3431

Closed
brsbl wants to merge 3 commits into
bb/plugin-row-actions-v1-thr_ccffp4w2p2from
bb/plugin-detail-tabs-thr_fckf9yhnnx
Closed

Open plugin details without leaving the workspace#3431
brsbl wants to merge 3 commits into
bb/plugin-row-actions-v1-thr_ccffp4w2p2from
bb/plugin-detail-tabs-thr_fckf9yhnnx

Conversation

@brsbl

@brsbl brsbl commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Human comments

What was wrong

  • View details in a plugin row switched to the Plugins workspace, interrupting the current thread or plugin page. Detail tabs were available only inside Plugin Guide.

What changed

  • Consolidated into Add plugin row actions and detail tabs; fix disable navigation and mobile sidebar access #2916 at ec3051b18d14208194e2e15a1966d3e010aa5cdd at the user's request. Use that PR and its localhost:16770 app for combined QA. The user approved closing this original layer as superseded; its branch and review history are preserved. Do not merge this duplicate layer independently.

  • Opens or focuses a plugin detail tab in the current new-thread, thread, or plugin workspace without changing its route. Existing panel tabs remain available; closing details returns to them.

  • Reuses the existing detail content and panel layout. Detail tabs are local to the mounted workspace, like the previous Plugin Guide detail tabs; no persisted tab, SDK, server, or daemon contracts change.

  • Keeps direct plugin launch and Disable unchanged. This layer does not change mobile sidebar controls.

How you verified

  • User QA pass (2026-09-11): the user explicitly reported that Open plugin details without leaving the workspace #3431 detail tabs passes QA against the running layer dev app (checkout 351f6834db8c6cae76ef4781bab27ef3aa66b112). Browser/version/viewport were not supplied. Reuse this result for the unchanged detail-tab flow during the requested consolidation into Add plugin row actions and detail tabs; fix disable navigation and mobile sidebar access #2916; do not count it as a new code review or a complete screenshot refresh.

  • Inherited disable-flow fix (2026-09-11): current head 351f6834db8c6cae76ef4781bab27ef3aa66b112 replays this unchanged layer onto Add plugin row actions and detail tabs; fix disable navigation and mobile sidebar access #2916's fix: close only the disabled plugin's workspace panes before unloading, preserve other splits, and replace the active route with its survivor or New thread. Remote CI 34561965770 completed: all tests, build/typecheck/lint, and Linux/macOS package smoke passed; only the startup bundle guard failed, at 1696.1 KB versus 1683.2 KB (12.9 KB over). The Add plugin row actions and detail tabs; fix disable navigation and mobile sidebar access #2916 exact-head regression run is green; its current-main merge candidate has a 0.7 KB startup bundle overage. Existing layer-specific bundle/QA blockers are unchanged. No additional deliberate review ran. Current Chrome for Testing launch is blocked after one recovery attempt; historical screenshots are not exact-current-head proof.

  • Rebase update (2026-09-10): current head 50a209ff01051afbcbef6a4299f3c3a1e8035c3a includes main@10bacbc0fb1ead6c1f1a728b395bdb1f60e52f93, including the muted navigation More styling. All commits replayed unchanged (git range-diff); no conflict resolutions, additional code review, or product changes. Remote CI run 34530483287 finished: all tests, build, typecheck, lint, and Linux/macOS package smoke passed; the existing startup bundle guard failed at 1694.3 KB versus 1683.2 KB (11.0 KB over). The comparison screenshots and UI results below belong to the explicitly recorded pre-rebase revisions and are retained as historical evidence, not exact-current-head verification. Existing readiness gaps remain open.

  • Added regression coverage for focused-workspace targeting, repeated opens, existing-tab selection, detail-tab closing, workspace reset, route preservation, and the sidebar-to-panel mobile transition.

  • Remote CI run 34527856620 on 497d201a48565a2494ef4d58eff9b254bd7e8b18: all app/server/integration/package tests, typecheck, lint, build, and Linux/macOS package smoke passed. The startup bundle guard failed: 1692.8 KB raw versus a 1683.2 KB budget, over by 9.5 KB. No budget increase or local CI-equivalent checks.

  • Chrome for Testing 153.0.8010.36: exact-head desktop and mobile View details retains /; a settled Automations workspace retains /plugins/automations/automations and its content. Existing New tab remains selectable alongside details. Mobile details render without making the app root inert. Focus, deduplication, closing, and workspace reset have passing remote regression coverage.

  • HOLD: clicking View details before a plugin workspace finishes mounting can still take the old /plugins/plugin-api-docs fallback. A real existing-thread UI flow remains unrun; shared state and focused-pane targeting are covered remotely. Both this loading-time edge case and the bundle guard need resolution before readiness. No additional deliberate code review ran; this PR remains draft and unmerged.

  • Screenshots below use the same isolated source app and enabled first-party builtin:plugin-api-docs fixture, light theme, scale 1, and action sequence: start at /, open the Plugin Guide row menu, select View details. Mobile opens the sidebar first. Before changes workspace to Plugins; its mobile sidebar-dismissal race also closes the details. After remains at / and keeps details open. Captures were inspected and uploaded as GitHub attachments, outside product commits; get-bb/reports was not used.

Before: parent 9ff3761403f5feab1548d229b537d2c0221b5cb1.

After: head 497d201a48565a2494ef4d58eff9b254bd7e8b18.

Layout Before After
Web/desktop — 1440×900 Before: details switches to Plugins After: details tab alongside the unchanged new-thread workspace
Mobile — 390×844, touch Before: switching workspaces and dismissing the sidebar loses the detail panel After: detail tab remains open in the current workspace

BB-Thread-ID: thr_fckf9yhnnx

AGENT GENERATED

@brsbl
brsbl added this pull request to stack #2980 September 10, 2026 20:34
@brsbl
brsbl force-pushed the bb/plugin-row-actions-v1-thr_ccffp4w2p2 branch from 9ff3761 to 5a95378 Compare September 10, 2026 21:08
@brsbl
brsbl force-pushed the bb/plugin-detail-tabs-thr_fckf9yhnnx branch from 497d201 to 50a209f Compare September 10, 2026 21:08
@brsbl

brsbl commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator Author

Closed as superseded by #2916 with the user's approval. All approved changes are consolidated at ec3051b. Branch and review history are preserved; no merge was performed.

AGENT GENERATED

@brsbl brsbl closed this Sep 11, 2026
@brsbl
brsbl removed this pull request from stack #2980 September 11, 2026 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant