Skip to content

Keep mobile workspace sidebar controls reachable - #3432

Closed
brsbl wants to merge 1 commit into
bb/plugin-detail-tabs-thr_fckf9yhnnxfrom
bb/mobile-workspace-sidebar-toggle-thr_fckf9yhnnx
Closed

Keep mobile workspace sidebar controls reachable#3432
brsbl wants to merge 1 commit into
bb/plugin-detail-tabs-thr_fckf9yhnnxfrom
bb/mobile-workspace-sidebar-toggle-thr_fckf9yhnnx

Conversation

@brsbl

@brsbl brsbl commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Human comments

What was wrong

  • Full-screen mobile detail panels hid the left sidebar toggle, making workspace navigation unavailable until the right panel was closed.

What changed

  • Consolidated into Add plugin row actions and detail tabs; fix disable navigation and mobile sidebar access #2916 at ec3051b18d14208194e2e15a1966d3e010aa5cdd at the user's request. Use that PR and its localhost:16770 app for combined QA. The user approved closing this original layer as superseded; its branch and review history are preserved. Do not merge this duplicate layer independently.

  • Keeps the shared mobile sidebar toggle above full-screen detail panels and reserves space beside their tabs so the controls do not overlap.

  • Covers Plugins, plugin detail and plugin-page routes, Settings, and Skills. Their existing open/collapse behavior stays available; desktop stacking and partial-height shelf spacing remain unchanged.

  • No sidebar menu, workspace layout, palette, or persisted/public-contract changes.

How you verified

  • Inherited disable-flow fix (2026-09-11): current head 55f06c8856abf69291f2e8856b4178d63cf92826 replays this unchanged layer onto Add plugin row actions and detail tabs; fix disable navigation and mobile sidebar access #2916's fix: close only the disabled plugin's workspace panes before unloading, preserve other splits, and replace the active route with its survivor or New thread. Remote CI 34561965981 completed: all tests, build/typecheck/lint, and Linux/macOS package smoke passed; only the startup bundle guard failed, at 1696.1 KB versus 1683.2 KB (12.9 KB over). The Add plugin row actions and detail tabs; fix disable navigation and mobile sidebar access #2916 exact-head regression run is green; its current-main merge candidate has a 0.7 KB startup bundle overage. Existing layer-specific bundle/QA blockers are unchanged. No additional deliberate review ran. Current Chrome for Testing launch is blocked after one recovery attempt; historical screenshots are not exact-current-head proof.

  • Rebase update (2026-09-10): current head 271985bd6e20392a1ddf5fe5515805752e782992 includes main@10bacbc0fb1ead6c1f1a728b395bdb1f60e52f93, including the muted navigation More styling. All commits replayed unchanged (git range-diff); no conflict resolutions, additional code review, or product changes. Remote CI run 34530485238 finished: all tests, build, typecheck, lint, and Linux/macOS package smoke passed; the existing startup bundle guard failed at 1694.3 KB versus 1683.2 KB (11.0 KB over). The comparison screenshots and UI results below belong to the explicitly recorded pre-rebase revisions and are retained as historical evidence, not exact-current-head verification. Existing readiness gaps remain open.

  • Added mobile route coverage for opening and collapsing the sidebar across all five surfaces, plus full-screen stacking and tab-spacing assertions.

  • Chrome for Testing 153.0.8010.36, exact parent/head: the mobile plugin-detail page changes from zero left toggles to one hit-testable control. Its right edge is 48 px; tabs begin at 56 px, leaving an 8 px gap. The app root stays non-inert.

  • Exact-head mobile opening/collapse cycles passed on Plugins, plugin details, the Automations plugin workspace, Settings, and Skills. Opening the sidebar from full-screen plugin details preserves the existing single-shelf behavior: the detail panel closes and the Plugins sidebar opens. Desktop retains the existing layout and the Automations route/content alongside details.

  • Remote CI run 34528272301 on e1e397aea612193351587af1b1319aa96c02dc11: all app/server/integration/package tests, typecheck, lint, build, and Linux/macOS package smoke passed. Checks failed only on the inherited startup bundle overage: 1692.7 KB raw versus the 1683.2 KB budget, over by 9.5 KB. No local CI-equivalent checks.

  • HOLD: inherited bundle failure and the detail-tab parent's loading-time fallback remain unresolved. This layer has no observed mobile-control defect, but remains draft and unmerged. No additional deliberate code review ran.

  • Evidence uses this task's isolated source app, the same enabled builtin:plugin-api-docs fixture and empty Automations workspace, light theme, scale 1, and matching routes/interactions. Mobile compares direct /plugins/plugin-api-docs navigation; desktop starts at /plugins/automations/automations and selects Plugin Guide → View details after the workspace settles. Inspected screenshots are GitHub attachments, not product commits; get-bb/reports was not used.

Before: parent 497d201a48565a2494ef4d58eff9b254bd7e8b18.

After: head e1e397aea612193351587af1b1319aa96c02dc11.

Layout Before After
Web/desktop — 1440×900, unchanged Before: plugin workspace and details tab After: desktop plugin workspace and details tab unchanged
Mobile — 390×844, touch Before: full-screen plugin details hides the left sidebar control After: sidebar control remains accessible beside the detail tabs
  • Additional exact-head mobile coverage at the same 390×844 viewport confirms existing Settings and Skills controls remain reachable:
Settings Skills
Settings sidebar control Skills sidebar control
  • Post-rebase UI check — 271985bd6: Chrome for Testing 153.0.8010.36, light theme, empty synthetic workspace at /, desktop 1440×900 and mobile 390×844. More uses the muted token at rest and sidebar foreground while open. The open/close cycle passed on both viewports and the app root stayed non-inert. These inspected current-head snapshots verify inherited main styling, not a refresh of the historical feature comparisons above.
Post-rebase web/desktop Post-rebase mobile
Current-head muted More on desktop Current-head muted More on mobile

BB-Thread-ID: thr_fckf9yhnnx

AGENT GENERATED

@brsbl
brsbl added this pull request to stack #2980 September 10, 2026 20:46
@brsbl
brsbl force-pushed the bb/mobile-workspace-sidebar-toggle-thr_fckf9yhnnx branch from e1e397a to 271985b Compare September 10, 2026 21:08
@brsbl
brsbl force-pushed the bb/plugin-detail-tabs-thr_fckf9yhnnx branch from 497d201 to 50a209f Compare September 10, 2026 21:08
@brsbl

brsbl commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator Author

Closed as superseded by #2916 with the user's approval. All approved changes are consolidated at ec3051b. Branch and review history are preserved; no merge was performed.

AGENT GENERATED

@brsbl brsbl closed this Sep 11, 2026
@brsbl
brsbl removed this pull request from stack #2980 September 11, 2026 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant