Repository navigation
EwoksExecutor: completion signals after start signals, finished for every execution - #509
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
0245b75 to
1a84e82
Compare
| """Emitted when a task finishes (success, failure, or stop request).""" | ||
| """Emitted last, for every submitted task.""" | ||
|
|
||
| _done = Signal(object, object, object) |
There was a problem hiding this comment.
I think the three objects could be more typed (futures.Future[VariableContainer], TaskFuture, and _controllers.TaskController).
But is seems (to be confirmed) that only the TaskFuture is required - _handle_done only uses the task_future if I am correct. That would simplify and aligned things.
There was a problem hiding this comment.
Indeed, only task_future is used. _done and _handle_done now take just that.
| raw_future: futures.Future[VariableContainer], | ||
| task_future: TaskFuture, | ||
| controller: _controllers.TaskController, | ||
| queue_done: bool, |
There was a problem hiding this comment.
The queue_done is not really helping IMO. This is True when the executor exists. AI suggest defer_completion that seems fair to me.
| queue_done: bool, | |
| defer_completion: bool, |
There was a problem hiding this comment.
Renamed to defer_completion.
1a84e82 to
04e56ab
Compare
…nd every execution with finished, and release a failed submission Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
04e56ab to
d8ae60b
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Stack (split from #501, merge in order):
PR summary
_donesignal, queued to the executor thread.finished.cancelledandfinished. The widget no longer stays pending.stop_requested→stopRequested, emitted with the completion.submit()no longer leaves the executor busy.AI Disclosure
🤖 Generated with Claude Code