Skip to content

Rename TaskFuture.abort/aborted to request_stop/stop_requested - #507

Merged
woutdenolf merged 1 commit into
mainfrom
request_stop_rename
Oct 22, 2026
Merged

woutdenolf merged 1 commit into
mainfrom
request_stop_rename

Conversation

@woutdenolf

@woutdenolf woutdenolf commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Stack (split from #501, merge in order):

  1. Qt test fixes: drop test_owwidget_drop timing dependency, fix Windows crash at exit #506 Qt test fixes: drop test_owwidget_drop timing dependency, fix Windows crash at exit
  2. Rename TaskFuture.abort/aborted to request_stop/stop_requested #507 Rename TaskFuture.abort/aborted to request_stop/stop_requested 👈 this PR
  3. Never start a queued task that is cancelled or stopped; two queues for the process backend #508 Never start a queued task that is cancelled or stopped; two queues for the process backend
  4. EwoksExecutor: completion signals after start signals, finished for every execution #509 EwoksExecutor: completion signals after start signals, finished for every execution
  5. Execute subprocess tasks with pebble, add TaskFuture.abort and TaskFuture.kill #501 Execute subprocess tasks with pebble, add TaskFuture.abort and TaskFuture.kill
  6. Doc: executor contract, backend diagrams and glossary #510 Doc: executor contract, backend diagrams and glossary

PR summary

  • Rename only, no behavior change (not released yet):
    • TaskFuture.abort → request_stop
    • TaskFuture.aborted → stop_requested
    • the executor signal aborted → stop_requested
  • Frees the name abort for a forced interrupt (later PR).

AI Disclosure

  • AI tools claude used for generate the code

🤖 Generated with Claude Code

…op_requested

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.79592% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...c/ewoksorange/gui/concurrency/_runners/abstract.py 75.00% 2 Missing ⚠️
...rc/ewoksorange/gui/concurrency/_runners/process.py 60.00% 2 Missing ⚠️
src/ewoksorange/gui/owwidgets/base.py 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@payno

payno commented Oct 22, 2026

Copy link
Copy Markdown
Member

To clarify (and also a note for myself): https://github.com/ewoks-kit/ewoksorange/pull/490/commits updated existing existing ewoksorange call of ewoks Task to the new naming convention.
This PR rename the ewoksorange rename the ewoksorange API.

@payno
payno self-requested a review October 22, 2026 07:26
@woutdenolf
woutdenolf changed the base branch from qt_test_fixes to main October 22, 2026 08:40
@woutdenolf
woutdenolf merged commit 8c76453 into main Oct 22, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants