Skip to content

Qt test fixes: drop test_owwidget_drop timing dependency, fix Windows crash at exit - #506

Merged
woutdenolf merged 2 commits into
mainfrom
qt_test_fixes
Oct 22, 2026
Merged

woutdenolf merged 2 commits into
mainfrom
qt_test_fixes

Conversation

@woutdenolf

@woutdenolf woutdenolf commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Stack (split from #501, merge in order):

  1. Qt test fixes: drop test_owwidget_drop timing dependency, fix Windows crash at exit #506 Qt test fixes: drop test_owwidget_drop timing dependency, fix Windows crash at exit 👈 this PR
  2. Rename TaskFuture.abort/aborted to request_stop/stop_requested #507 Rename TaskFuture.abort/aborted to request_stop/stop_requested
  3. Never start a queued task that is cancelled or stopped; two queues for the process backend #508 Never start a queued task that is cancelled or stopped; two queues for the process backend
  4. EwoksExecutor: completion signals after start signals, finished for every execution #509 EwoksExecutor: completion signals after start signals, finished for every execution
  5. Execute subprocess tasks with pebble, add TaskFuture.abort and TaskFuture.kill #501 Execute subprocess tasks with pebble, add TaskFuture.abort and TaskFuture.kill
  6. Doc: executor contract, backend diagrams and glossary #510 Doc: executor contract, backend diagrams and glossary

PR summary

  • test_owwidget_drop: no longer depends on the duration of a task.
  • ewoksorange_qtapp teardown: delete the remaining Python-owned Qt objects.
    • Fixes a random crash (access violation in PyQt's exit cleanup) after the test session on Windows.

AI Disclosure

  • AI tools claude used for generate the code

🤖 Generated with Claude Code

woutdenolf and others added 2 commits October 21, 2026 11:28
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…cts to avoid a crash at exit on Windows

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@payno payno added this to the v6.0.0 milestone Oct 22, 2026
@woutdenolf
woutdenolf merged commit b26e0a4 into main Oct 22, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants