Styles/MenuButton: fix default icon, add an example menu - #1027
Merged
Merged
Conversation
danirabbit
force-pushed
the
danirabbit/menubutton-fixicon-addmenu
branch
from
September 8, 2026 21:11
4d618f5 to
1a15d4b
Compare
danirabbit
marked this pull request as ready for review
September 8, 2026 21:12
leolost2605
approved these changes
Sep 17, 2026
leolost2605
left a comment
leolost2605
left a comment
Member
There was a problem hiding this comment.
One nit, apart from that LGTM
Co-authored-by: Leonhard <leo.kargl@proton.me>
danirabbit
enabled auto-merge (squash)
September 17, 2026 13:50
danirabbit
disabled auto-merge
September 19, 2026 17:29
ryonakano
reviewed
Sep 20, 2026
Comment on lines
+2
to
5
| // Assuming use case as a main menu button | ||
| > button.image-button arrow.down { | ||
| -gtk-icon-source: -gtk-icontheme("open-menu-symbolic"); | ||
| } |
Member
There was a problem hiding this comment.
I think this change introduces #1012 again, while I admit my first code applies to all arrow types. I'll make a followup PR to do the equivalent thing with what libadwaita does.
Member
There was a problem hiding this comment.
Or simply make sure this is applied to arrow.none too.
Member
There was a problem hiding this comment.
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes making the default icon open-menu since in modern gtk it does get a direction style class.
While we're here, add a basic example menu that can build on in future PRs to expand PopoverMenu support