menubutton: Fix default icon

[ryonakano]

Backport of elementary/granite#1027 and elementary/granite#1055

File Roller built with this branch (d58fee2):

It still shows the arrow icons if you specify Gtk.ArrowType.UP for example:

A patch to build this branch inside the sanbox

diff --git a/org.gnome.FileRoller.json b/org.gnome.FileRoller.json
index 8450685..dc831bd 100644
--- a/org.gnome.FileRoller.json
+++ b/org.gnome.FileRoller.json
@@ -99,6 +99,65 @@
                 }
             ]
         },
+        {
+            "name": "stylesheet",
+            "buildsystem": "meson",
+            "sources": [
+                {
+                    "type": "git",
+                    "url": "https://github.com/elementary/stylesheet.git",
+                    "commit": "d58fee241beaded878bd518932b79a7436675a77",
+                    "x-checker-data": {
+                        "type": "git",
+                        "tag-pattern": "^([\\d.]+)$"
+                    }
+                }
+            ],
+            "modules": [
+                {
+                    "name": "sassc",
+                    "cleanup": [
+                        "*"
+                    ],
+                    "sources": [
+                        {
+                            "type": "git",
+                            "url": "https://github.com/sass/sassc.git",
+                            "tag": "3.6.2"
+                        },
+                        {
+                            "type": "script",
+                            "dest-filename": "autogen.sh",
+                            "commands": [
+                                "autoreconf -si"
+                            ]
+                        }
+                    ],
+                    "modules": [
+                        {
+                            "name": "libsass",
+                            "cleanup": [
+                                "*"
+                            ],
+                            "sources": [
+                                {
+                                    "type": "git",
+                                    "url": "https://github.com/sass/libsass.git",
+                                    "tag": "3.6.5"
+                                },
+                                {
+                                    "type": "script",
+                                    "dest-filename": "autogen.sh",
+                                    "commands": [
+                                        "autoreconf -si"
+                                    ]
+                                }
+                            ]
+                        }
+                    ]
+                }
+            ]
+        },
         {
             "name": "file-roller",
             "buildsystem": "meson",

[danirabbit]

Are you sure this is correct for GTK3? Do we have a test case for this? A lot of selectors changed between 3 and 4

[ryonakano]

I haven't tested for GTK 3. And now I noticed .image-button isn't mentioned in the GTK 3 version of the documentation so this may not work……I'll check what I should do for GTK 3.

• https://docs.gtk.org/gtk3/class.MenuButton.html#css-nodes
• https://docs.gtk.org/gtk4/class.MenuButton.html#css-nodes

[ryonakano]

Are you sure this is correct for GTK3?

It's not correct 😵

GTK 3 (granite-demo):

GTK 4 (granite-9-demo):

[ryonakano]

It looks like we have no way to get the direction in CSS in GTK 3? So probably we should remove src/gtk-3.0/widgets/_menubuttons.scss itself.

[ryonakano]

Removed in 3a3144a