-
-
Notifications
You must be signed in to change notification settings - Fork 65
Styles/MenuButton: fix default icon, add an example menu #1027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+64
−46
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
1a15d4b
Styles/MenuButton: fix default icon, add an example menu
danirabbit 77cb90a
Merge branch 'main' into danirabbit/menubutton-fixicon-addmenu
danirabbit 9b53049
Merge branch 'main' into danirabbit/menubutton-fixicon-addmenu
danirabbit 91682a8
Merge branch 'main' into danirabbit/menubutton-fixicon-addmenu
danirabbit 9e2d473
Merge branch 'main' into danirabbit/menubutton-fixicon-addmenu
danirabbit 2085a5e
Merge branch 'main' into danirabbit/menubutton-fixicon-addmenu
danirabbit d6b5703
Merge branch 'main' into danirabbit/menubutton-fixicon-addmenu
danirabbit a6d74a9
Put switchmodelbutton in the same menu
danirabbit 5c4ad45
Merge main
danirabbit cd1f546
Merge branch 'main' into danirabbit/menubutton-fixicon-addmenu
danirabbit d8372b5
Merge branch 'main' into danirabbit/menubutton-fixicon-addmenu
danirabbit c802eb3
Update ControlsView.vala
danirabbit 207ffab
Merge branch 'main' into danirabbit/menubutton-fixicon-addmenu
danirabbit 39e0b26
merge main
danirabbit 8b55c8e
Merge branch 'main' into danirabbit/menubutton-fixicon-addmenu
danirabbit 8341ffd
Merge branch 'main' into danirabbit/menubutton-fixicon-addmenu
danirabbit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,6 @@ | ||
| menubutton { | ||
| arrow { | ||
| // Use non-arrow icon when no direction specified, assuming use case as a | ||
| // main menu button | ||
| // Assuming use case as a main menu button | ||
| > button.image-button arrow.down { | ||
| -gtk-icon-source: -gtk-icontheme("open-menu-symbolic"); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change introduces #1012 again, while I admit my first code applies to all arrow types. I'll make a followup PR to do the equivalent thing with what libadwaita does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or simply make sure this is applied to
arrow.nonetoo.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened: