Repository navigation
fix: login keeps the account's other sessions - #32
Merged
Merged
Conversation
Closes #30 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30.
Login called
sessions.revokeAll(user.id), so a second browser or device signing in logged out the first. The public site login doesn't do that, and it isn't needed against session fixation (each login gets a fresh id). Sessions still end on logout, password change (revokeAllin the password endpoint,users:passwd) and expiry.No test: the login route handler has no existing test harness; the one-line removal is covered by the existing
SessionManagertests plusdeno task check.🤖 Generated with Claude Code