Repository navigation
feat: edit taxonomy terms in the page editor - #34
Merged
Merged
Conversation
Closes #31 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… right after typing a term addTerm matches existing terms case-insensitively (core keys terms by the raw string) and reuses the spelling already used on the site. A pasted 'a, b' becomes two terms. The Unsaved badge is always laid out so the blur that dirties the page no longer moves Save out from under the click, and save() reads the latest frontmatter from a ref. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… term matching and Save fix Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
zumbrunn
force-pushed
the
feat/page-editor-taxonomy-31
branch
from
November 12, 2026 10:16
4af02cf to
c559f5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31.
The page editor sidebar gets one control per site taxonomy (
site.taxonomies): terms as removable chips, an input to add (Enter, comma, or leaving the field) with the site's existing terms as datalist suggestions. Writestaxonomy.<name>as a list of terms. Core keys terms by the raw string, case-sensitively, so terms are not slugs: what you type is matched case-insensitively against the page's terms (no-op) and the site's existing terms (reuses that spelling), otherwise kept as typed. Pasting "a, b" adds two terms.taxonomyfield wins and the built-in control is hidden.taxonomynot an object) is shown as not editable and left untouched; other taxonomies' values are preserved when one is edited.taxonomyobject is dropped (null → the PUT handler deletes the key).taxonomyno longer counts as an unmanaged key while the control is shown.GET /admin/api/pages/:pathreturnstaxonomies(name → terms in use, most used first, capped at 500 per taxonomy).Tests cover the pure helpers (list/absent/non-list values, preserving others, empty handling, dedupe, case-insensitive matching) and the unmanaged-keys rule.
deno testpasses (316).Browser check (local site, this branch, built-in browser):
save()reads the latest frontmatter from a ref. After the fix the term is in the file after Save.baris already there. Removing a chip and saving rewrote the list correctly.taxonomy: { tag: solo }shows "not a plain list", and Save lefttag: solountouched.Also fixed: the
GET /admin/api/pagestest context had noconfig.site, which made two existing tests fail on this branch.Note: the CHANGELOG Unreleased section will conflict trivially with #32/#33; resolve by keeping all entries.
🤖 Generated with Claude Code