Skip to content

fix: login keeps the account's other sessions #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zumbrunn merged 1 commit into from
Nov 12, 2026
Merged

fix: login keeps the account's other sessions #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ follows [Semantic Versioning](https://semver.org).

## [Unreleased]

### Fixed

- **Signing in no longer ends the account's other admin sessions (#30).** Login revoked every existing session of the
user, so using the admin in two browsers or on two devices logged you out of the first one, with no hint why.
Sessions now end on logout, password change and expiry only.

## [4.0.1] — 2026-11-11

### Fixed
Expand Down
4 changes: 3 additions & 1 deletion src/admin/routes/login.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,9 @@ export const handler = {
}
}

await sessions.revokeAll(user.id);
// Deliberately no revokeAll here: signing in on a second browser or device
// must not end the first. Sessions are revoked on logout, password change
// and expiry.
const session = await sessions.create(user.id, ip === "unknown" ? undefined : ip);

// Successful login resets the per-account failure counter.
Expand Down
Loading