Repository navigation
docs(release): version by RPC, ABCI, P2P/consensus and block contracts - #1603
Conversation
Base SemVer on the contracts that node operators and Dash Platform depend on. A backward-incompatible change to RPC, ABCI, P2P/consensus or the block format is a major, including a new consensus version activated by a chain parameter. Exported Go APIs, configuration and CLI no longer affect the version; the changelog still documents them. Persisted data is not versioned, but storage changes must migrate automatically. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WunYYgcoPDNh3uebhUCwig
A BlockProtocol change is a full hard fork; the release skill must stop and get explicit confirmation of that specific change. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WunYYgcoPDNh3uebhUCwig
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
RELEASES.md is the single source of the versioning rules and protocol counter guidance; the release skill links to it and keeps only the review procedure and its stop-and-ask gates. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WunYYgcoPDNh3uebhUCwig
… them Branch/source roles, promotion and protection rules, artifact contents and Docker tag/alias rules live in RELEASES.md; the skill keeps the procedure, commands, verification steps and stop conditions. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WunYYgcoPDNh3uebhUCwig
|
✅ Final review complete — Phase 1 only — no blockers (commit 575b911) · triage: trivial |
* chore(release): prepare 2.0.0-dev.1 Bump TMVersionDefault to 2.0.0-dev.1, ABCISemVer to 1.5.0 and P2PProtocol to 11; BlockProtocol stays 14. Add the 2.0.0-dev.1 changelog section reviewed against v1.8.2..0e08aa0. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WunYYgcoPDNh3uebhUCwig * docs(changelog): separate breaking changes from migration notes List consensus and RPC incompatibilities under Breaking Changes and move Go API, configuration and CLI changes to Migration Notes, per the versioning policy proposed in #1603. Add the broadcast_evidence change from #1547. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WunYYgcoPDNh3uebhUCwig --------- Co-authored-by: Lukasz Klimek <842586+lklimek@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
- Check ABCISemVer changes against the rs-tenderdash-abci caret rule and prepare its PR before tagging. - Require an empty diff between the reviewed head and the merge commit, and generate release notes from the merged changelog. - Look up drafts by tag name. - Record stable Docker alias digests before publishing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WunYYgcoPDNh3uebhUCwig <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>
|
Waiting for bot review — thepastaclaw not yet. Wait for the missing reviews, or a writer can post |
thepastaclaw
left a comment
There was a problem hiding this comment.
Final review — Phase 1 only (trivial change)
Verified the documentation changes at 8ba22c2 and found no actionable issue in the supplied finding. The README summarizes the release policy rather than claiming that the node contains a universal migration mechanism. Current build, test, lint, and release-tooling checks pass; PastaClaw review and PR Hygiene remain pending.
Review provenance
Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); final verifier: gpt-6.1-sol (agent: sol-gate-verifier, role: final-verifier)
- Triage:
trivialbygpt-6.1-sol(effort low) — The diff changes only release-policy documentation and procedural guidance, with no executable behavior or protocol changes. - Phase 1 reviewers:
glm-5.3-flash— general (completed, effort high); agentphase1-reviewer - Phase 1 model:
glm-5.3-flash— zai quota: 5h 70% left, weekly 94% left; passed overgemini-3.8-flash-high(antigravity quota lookup failed) - Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-gate-verifier - Phase 2 reviewers: not run (triage rated this change trivial); this review comments and never approves
|
Policy satisfied — this can merge. |
… checks - After the Tenderdash release, rerun the rs-tenderdash-abci PR CI, merge, tag the same version on develop and publish a GitHub release; the PR already carries the version bump. - Check the deployed Platform release: Drive's tenderdash-abci ABCI range, dashmate's pinned Tenderdash image, and dashmate's default Tenderdash configuration against new validation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WunYYgcoPDNh3uebhUCwig <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>
|
Waiting for bot review — thepastaclaw not yet. Wait for the missing reviews, or a writer can post |
thepastaclaw
left a comment
There was a problem hiding this comment.
Re-review — Final review — Phase 1 only (trivial change)
The documentation-only changes consistently define versioning around RPC, ABCI, P2P/consensus, and block-format contracts, while preserving the release procedure and required safety gates. The changed links, policy details, and cross-repository verification guidance are coherent with the repository structure and existing release tooling; CI shows no failed code checks attributable to this change, with only review-hygiene checks still pending.
🔴 0 blocking | 🟡 0 suggestion(s) | 💬 0 nitpick(s)
Review provenance
Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); final verifier: gpt-6.1-sol (agent: sol-gate-verifier, role: final-verifier)
- Triage:
trivialbygpt-6.1-sol(effort low) — This is a documentation and release-process change with no production behavior, consensus logic, storage migration, or other runtime impact. - Phase 1 reviewers:
glm-5.3-flash— general (completed, effort high); agentphase1-reviewer - Phase 1 model:
glm-5.3-flash— zai quota: 5h 95% left, weekly 92% left; passed overgemini-3.8-flash-high(antigravity quota lookup failed) - Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-gate-verifier - Phase 2 reviewers: not run (triage rated this change trivial); this review comments and never approves
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify the current code and confirm that no unresolved issues remain.
No unresolved findings remain from the prior review on this head.
|
Ready for review — files with no dedicated owner: lklimek or shumkov. |
|
Policy satisfied — this can merge. |
TL;DR: Tenderdash version numbers follow what node operators and Dash Platform depend on: RPC, ABCI, P2P/consensus and the block format. A new consensus version is always a major release.
User story
As a node operator, I want a major version to mean that I must upgrade to keep following the network, to plan upgrades from the version number alone.
Scenario
Base flow
A maintainer prepares a release and picks its version with the
tenderdash-releaseskill.Actual behavior
The policy treats the exported Go API, configuration, CLI and storage like network contracts. As a result:
Expected behavior
Detailed discussion
What was done
RELEASES.mdis the single source of release rules. Its new "Versioning policy" section contains:BlockProtocolbump implies a major and, as a full hard fork, requires explicit confirmation of that specific change..agents/skills/tenderdash-release/SKILL.mdkeeps only the procedure:BlockProtocol, manual storage migration, another deployed line.For rules it links to
RELEASES.md: versioning policy, branches and release sources, promotion and protections, artifact contents, and Docker tags and aliases.The skill also adds verification steps that came out of releasing v2.0.0-dev.1:
ABCISemVerchange against the rs-tenderdash-abcicheck_versioncaret rule and prepare its PR before tagging;developand publish a GitHub release;tenderdash-abciABCI range, the Tenderdash image dashmate pins, and dashmate's default Tenderdash configuration against new validation.README.md: the SemVer summary is updated to match.CONTRIBUTING.md: links to the policy.Testing
python3 -B -m unittest discover -s scripts/release -p test_release.py: OKsh scripts/test-local-gates.sh: passedmarkdownlint-cli@0.45.0 --config .markdownlint.ymlon the edited files: cleanBreaking changes
None. This changes only documentation and process. Under this policy, v2.0.0-dev.1 (#1602) is still a major because it adds
CONSENSUS_VERSION_2and changesbroadcast_txRPC behavior.Prior work
Attribution
Prepared with Claude Code (Claude Opus 5.5).
🤖 Generated with Claude Code
https://claude.ai/code/session_01WunYYgcoPDNh3uebhUCwig
🤖 Co-authored by Claudius the Magnificent AI Agent
PR Hygiene ·
575b911.agents/skills/tenderdash-release/SKILL.md,CONTRIBUTING.md,README.mdand 1 more) — approved by lklimekWhen every merge requirement is met, the
PR Hygienecheck passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.