Repository navigation
chore(release)!: prepare 2.0.0-dev.1 - #1602
Conversation
Bump TMVersionDefault to 2.0.0-dev.1, ABCISemVer to 1.5.0 and P2PProtocol to 11; BlockProtocol stays 14. Add the 2.0.0-dev.1 changelog section reviewed against v1.8.2..0e08aa0. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WunYYgcoPDNh3uebhUCwig
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
|
✅ Final review complete — no blockers (commit cb19e3d) · triage: low |
|
/skip-bots |
List consensus and RPC incompatibilities under Breaking Changes and move Go API, configuration and CLI changes to Migration Notes, per the versioning policy proposed in #1603. Add the broadcast_evidence change from #1547. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WunYYgcoPDNh3uebhUCwig
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — Phase 1 + Phase 2
Verified the release-preparation diff at cb19e3d and confirmed three non-blocking release-documentation inconsistencies. No blocking defect was established in the version updates or their compatibility consumers. This was a static review; current CI shows all build, test, and lint checks passing, with only the automated review pending.
🟡 3 suggestion(s)
2 finding(s) not shown inline (the lines are not part of this PR's diff)
🟡 Suggestion: Align the published RPC reference with the release version
rpc/openapi/openapi.yaml:52-55
The RPC reference still identifies itself as v1.8-dev and links the license to that branch, while this PR prepares v2.0.0-dev.1 with explicitly changed RPC contracts. scripts/prepare-docs.py copies rpc/openapi verbatim into the published documentation; DOCS_SOURCE_REF rewrites Markdown source links, not this YAML metadata. This is a missed sibling version marker in release preparation: update it so the reference accompanying the release does not identify the previous development line.
version: "v2.0.0-dev.1"
license:
name: Apache 2.0
url: https://github.com/dashpay/tenderdash/blob/v2.0.0-dev.1/LICENSE
source: glm-5.3-flash (phase1-reviewer: general)
🟡 Suggestion: Associate the upgrade instructions with this prerelease
UPGRADING.md:5
The Unreleased section contains the P2P startup validation, service-lifecycle, commit vote-extension verification, and cached transaction-rejection changes included in this release. Leaving these instructions unversioned while assigning the release makes it unclear which upgrade first requires those actions, particularly once subsequent development adds more notes. File the existing section under v2.0.0-dev.1, consistent with the version-specific purpose of this guide and the earlier v1.7.0 organization; future changes can start a new Unreleased section.
## v2.0.0-dev.1
source: glm-5.3-flash (phase1-reviewer: general)
Review provenance
Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)
- Triage:
lowbygpt-6.1-sol(effort low) — The diff is limited to release notes and three version constants, making it small and well-contained without changing consensus rules or protocol implementations. - Phase 1 reviewers:
glm-5.3-flash— general (completed, effort high); agentphase1-reviewer - Phase 1 model:
glm-5.3-flash— zai quota: 5h 97% left, weekly 99% left; passed overgemini-3.8-flash-high(antigravity quota lookup failed) - Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-verifier - Phase 2 reviewers:
gpt-6.1-sol— general (completed, effort medium); agentphase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.
In `CHANGELOG.md`:
- [SUGGESTION] CHANGELOG.md:77: Describe the net linter change rather than the superseded pin
The release notes advertise a golangci-lint v2.14.0 pin, but Makefile, go.mod, and the lint workflow all specify v2.15.0 at both the v1.8.2 baseline and this release head. Although #1524 temporarily introduced that pin, subsequent changes superseded it before this release. The actual net change is the migration from gomodguard to gomodguard_v2; retain that migration without naming a linter version the release does not ship.
In `rpc/openapi/openapi.yaml`:
- [SUGGESTION] rpc/openapi/openapi.yaml:52-55: Align the published RPC reference with the release version
The RPC reference still identifies itself as v1.8-dev and links the license to that branch, while this PR prepares v2.0.0-dev.1 with explicitly changed RPC contracts. scripts/prepare-docs.py copies rpc/openapi verbatim into the published documentation; DOCS_SOURCE_REF rewrites Markdown source links, not this YAML metadata. This is a missed sibling version marker in release preparation: update it so the reference accompanying the release does not identify the previous development line.
In `UPGRADING.md`:
- [SUGGESTION] UPGRADING.md:5: Associate the upgrade instructions with this prerelease
The Unreleased section contains the P2P startup validation, service-lifecycle, commit vote-extension verification, and cached transaction-rejection changes included in this release. Leaving these instructions unversioned while assigning the release makes it unclear which upgrade first requires those actions, particularly once subsequent development adds more notes. File the existing section under v2.0.0-dev.1, consistent with the version-specific purpose of this guide and the earlier v1.7.0 organization; future changes can start a new Unreleased section.
| - Pin Docker workflow actions to commit SHAs and restrict token permissions (#1589) | ||
| - Replace Janitor with native PR concurrency (#1592) | ||
| - Migrate proto lint to buf-action (#1561) | ||
| - Pin golangci-lint to v2.14.0 and migrate to gomodguard_v2 (#1524) |
There was a problem hiding this comment.
🟡 Suggestion: Describe the net linter change rather than the superseded pin
The release notes advertise a golangci-lint v2.14.0 pin, but Makefile, go.mod, and the lint workflow all specify v2.15.0 at both the v1.8.2 baseline and this release head. Although #1524 temporarily introduced that pin, subsequent changes superseded it before this release. The actual net change is the migration from gomodguard to gomodguard_v2; retain that migration without naming a linter version the release does not ship.
| - Pin golangci-lint to v2.14.0 and migrate to gomodguard_v2 (#1524) | |
| - Migrate gomodguard to gomodguard_v2 (#1524) |
source: glm-5.3-flash (phase1-reviewer: general)
|
Ready for review — files with no dedicated owner: lklimek or shumkov. |
|
Policy satisfied — this can merge. |
TL;DR: Prepares the first Tenderdash 2.0 development prerelease,
v2.0.0-dev.1, so Dash Platform can test the changes collected ondevsincev1.8.2.User story
As a Dash Platform developer, I want a versioned Tenderdash 2.0 prerelease with release notes, to test the new consensus, P2P and storage behavior against Platform before a stable release.
Scenario
Base flow
Platform teams pick up Tenderdash through versioned releases and Docker images.
Actual behavior
The changes merged to
devsincev1.8.2are only available as unversioned branch builds, and no release notes describe their breaking changes.Expected behavior
After merge and tagging,
v2.0.0-dev.1is published as a GitHub prerelease with adashpay/tenderdash:2.0.0-dev.1image. Stable Docker aliases (latest,1,1.8) stay unchanged.Detailed discussion
What was done
version/version.go:TMVersionDefault1.8.2→2.0.0-dev.1,ABCISemVer1.4.0→1.5.0,P2PProtocol10→11.BlockProtocolstays14.CHANGELOG.md: new2.0.0-dev.1section with "Breaking Changes" (versioned contracts), "Migration Notes" (Go API, configuration, CLI) and protocol versions.Release context:
origin/dev@0e08aa05c256e8bbe6702e01f6af8b77050bdce8v1.8.2@dd596db0ddbde7e9a23754ddd6dbf6cc482fd9c1(latest stable, reachable from the candidate, currentmaster)scripts/release/plan.py --mode next)dev(first of the 2.0.0 series)Version decision:
Major (2.0.0). The release follows the versioning policy proposed in docs(release): version by RPC, ABCI, P2P/consensus and block contracts #1603: only the RPC, ABCI, P2P/consensus and block-format contracts set the version. Two of them change incompatibly:
CONSENSUS_VERSION_2(feat(consensus)!: hand a silent proposer's idle round to the next proposer #1572). Once a chain enables it, older nodes cannot follow that chain.broadcast_tx*return the cachedCheckTxrejection for resubmitted invalid transactions (feat(mempool)!: return cached CheckTx rejection for resubmitted transactions #1530).broadcast_evidencereturnsErrEvidenceDisabledwhile evidence is disabled (feat(evidence)!: follow live chain evidence settings #1547).Go API, configuration and CLI changes do not set the version under that policy. The changelog lists them under "Migration Notes": feat(consensus)!: hand a silent proposer's idle round to the next proposer #1572
PrivValidator, refactor(db)!: own GoLevelDB and memory database adapters #1551libs/db, refactor(indexer)!: remove PostgreSQL event sink #1553 psql, fix(p2p)!: enforce peer penalties and validate network settings #1550 P2P config, fix(service)!: share worker lifecycle for consensus shutdown #1513 shutdown timeout and fix(abci): reject DEFAULT vote extensions returned by ExtendVote #1565DEFAULTextensions.ABCISemVer1.5.0 (minor). ABCI consensus params gainCONSENSUS_VERSION_2and theproposer_heartbeat/proposer_silencetimeouts (feat(consensus)!: hand a silent proposer's idle round to the next proposer #1572). Both are additive, and the bump follows the precedent for new params fields (feat: allow defining validator power threshold in consensus params #1052 → 1.3.0, feat(abci): let the application ask for the next block without waiting for transactions #1466 → 1.4.0). rs-tenderdash-abci accepts^<major>.<minor>of its linked version, so Drive built against ABCI 1.4.x accepts 1.5.0. fix(abci): reject DEFAULT vote extensions returned by ExtendVote #1565 rejectsDEFAULTvote extensions fromExtendVote. Those extensions already failed in the signer or were rejected by peers, so the change narrows no supported behavior.P2PProtocol11. Three new state-channel messages (ProposerHeartbeat,RoundSkipVote,RoundSkipCertificate, Envelope fields 31–33) are sent only on chains at consensus version 2. The counter is informational:NodeInfocompatibility does not compare it.BlockProtocol14 (unchanged). Block and commit structures are unchanged. The consensus params hash covers the proposer timeouts only after a chain activates consensus version 2, and the hash for versions 0 and 1 stays the same. The counter is enforced strictly (types/block.go,node/setup.go), so bumping it would make existing chains invalid.Go module path. It stays
github.com/dashpay/tenderdash, without/v2. Go tooling does not resolvev2.xtags for this module, so Go consumers must pin commit pseudo-versions. Platform consumes Docker images and rs-tenderdash-abci, not the Go module. The changelog documents this.Dash Platform rollout:
psqlindexing, check P2P settings and set a supervisor grace period longer than--shutdown-timeout(30s).2.0.0-dev.1and never move stable aliases (scripts/tests/test_docker_metadata.py).After merge: tag
v2.0.0-dev.1at the reviewed merge SHA, create a draft GitHub prerelease, attach signed Linux amd64/arm64 binaries (scripts/release/build-artifacts.sh), then publish it, which triggersdocker.yml.Testing
On the candidate plus this branch (the CHANGELOG-only follow-up commit needs no extra checks):
python3 -B -m unittest discover -s scripts/release -p test_release.py: 12 tests OKpython3 -B -m unittest discover -s scripts/tests -p test_docker_metadata.py: 16 tests OKsh scripts/test-local-gates.sh: passed.shellcheck scripts/release/build-artifacts.sh: cleangofmt -l version/andgo vet ./version/: clean.go build ./...: OK (CGO + BLS)go test -count=1 -tags=deadlock ./version/... ./types/... ./abci/... ./internal/proxy/... ./node/...: all pass2.0.0-dev.1Not verified here (CI covers the full suite):
Breaking changes
This PR only changes release metadata. The prerelease it versions contains these breaking changes (
CHANGELOG.md"Breaking Changes"):CONSENSUS_VERSION_2; every node must upgrade before a chain enables itbroadcast_tx*return the cachedCheckTxrejection for resubmitted invalid transactionsbroadcast_evidencereturnsErrEvidenceDisabledwhile evidence is disabledOperator and integrator actions are listed under "Migration Notes".
Prior work
tenderdash-releaseskill. This is its first release.Attribution
Prepared with Claude Code (Claude Opus 5.5) using the
tenderdash-releaseskill.🤖 Generated with Claude Code
https://claude.ai/code/session_01WunYYgcoPDNh3uebhUCwig
🤖 Co-authored by Claudius the Magnificent AI Agent
PR Hygiene ·
cb19e3dCHANGELOG.md,version/version.go) — approved by lklimekWhen every merge requirement is met, the
PR Hygienecheck passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.