Repository navigation
chore: make dev the only development branch and drop v1.8-dev references - #1608
Conversation
AGENTS.md now tells agents to branch from origin/dev and open PRs into dev (stable hotfixes from master excepted), and states that vX.Y-dev branches are retired and must not be used even while they still exist on the remote. CONTRIBUTING.md says the same instead of hinting at choosing among historical versioned branches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit f5389e043bddba0a45fa8c6ff3dd37f8dbd0b85e)
- scripts/release/plan.py requires origin/dev and no longer falls back to origin/v1.8-dev; the test now asserts that versioned -dev branches never stand in for a missing dev. - scripts/prepare-docs.py links source files to dev by default (the Makefile still passes the exact SHA). - rpc/openapi/openapi.yaml advertises the Tenderdash version instead of a branch name, and links the license on master. A test in version/ keeps info.version equal to TMVersionDefault, and the release skill updates both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
|
✅ Final review complete — no blockers (commit ca4d9d2) · triage: low · Phase 2 only (queue backlog) |
|
Waiting for bot review — thepastaclaw not yet. Wait for the missing reviews, or a writer can post |
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — Phase 2 only (queue backlog)
Verified the changes at ca4d9d2 and the Phase 2 dismissals against the source; no actionable defects were found. The planner requires origin/dev while preserving release-source validation, documentation defaults use dev, and OpenAPI version synchronization has a regression test. Validation was static only: the supplied CI snapshot and current checks show passing code checks, with PR Hygiene and automated review pending; the newer base-policy commit neither supersedes these changes nor introduces reported merge conflicts.
Review provenance
Source: reviewer 1: gpt-6.1-sol (agent: phase2-reviewer, role: general); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)
- Triage:
lowbygpt-6.1-sol(effort low) — This is a small, contained documentation and development-tooling change with straightforward behavior updates and focused tests, without affecting consensus, funds, cryptography, networking, or storage. - Phase 1 reviewers: not run (skipped for throughput: 13 PRs queued, above the 10 limit)
- Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-verifier - Phase 2 reviewers:
gpt-6.1-sol— general (completed, effort medium); agentphase2-reviewer
|
Policy satisfied — this can merge. |
TL;DR: Makes
devthe only development branch in agent instructions, contributor docs, release tooling and the RPC API description, and removes leftover references to retiredvX.Y-devbranches.User story
As a contributor or AI agent working on Tenderdash, I want every instruction and tool to point at
dev, to avoid starting work from, or opening PRs against, a retiredvX.Y-devbranch.Scenario
Base flow
A contributor or agent starts a change, prepares a release, or reads the RPC API description.
Actual behavior
AGENTS.mdandCONTRIBUTING.mdcalldevthe integration branch, but also talk about choosing among "historical versioned" branches. OldvX.Y-devbranches still exist on the remote, and agents end up using them.v1.8-devwhendevhas not been fetched.v1.8-devby default.v1.8-devand links the license on that branch.Expected behavior
devand open PRs intodev; only stable hotfixes start frommaster;vX.Y-devbranches are retired.origin/dev.devby default.Detailed discussion
What was done
AGENTS.md,CONTRIBUTING.md: require work ondev(stable hotfixes frommasterexcepted);vX.Y-devbranches are retired and must not be branched from, targeted or compared against, even while they still exist on the remote.scripts/release/plan.py:integrationis alwaysorigin/dev; a missingorigin/devis an error instead of a fallback toorigin/v1.8-dev.scripts/prepare-docs.py: default--source-refisdev(the Makefile still passes the exactHEADSHA).rpc/openapi/openapi.yaml:info.versionis2.0.0-dev.1(TMVersionDefault); the license URL points atmaster.version/version_test.go:TestOpenAPIVersionMatchesTMVersionDefaultfails if the two versions differ..agents/skills/tenderdash-release/SKILL.md: release preparation updates the OpenAPIinfo.versiontogether withTMVersionDefault.Remaining
v1.8-devmentions are intentional:scripts/test-local-gates.shandscripts/release/test_release.pycreate such refs to check that they are never used.spec/consensus/consensus.mdis fixed in #1606.Testing
scripts/release/test_release.py:test_versioned_dev_branches_never_replace_missing_devfailed against the old fallback, passes now; the 12 tests pass.scripts/tests/test_prepare_docs.py: 9 tests pass.go test ./version/: the new test failed against the oldv1.8-devvalue, passes now.go vetis clean.ruff check/ruff format --checkand markdownlint are clean on the changed files (markdownlint still reports pre-existing MD007 warnings inAGENTS.md). golangci-lint is left to CI.Breaking changes
None for users.
plan.pynow fails whenorigin/devis not fetched instead of planning againstv1.8-dev.Prior work
CONTRIBUTING.mdand the release skill, in different lines; theAGENTS.mdchange was moved here so it does not restart that PR's reviews.v1.8-devnote inspec/consensus/consensus.md.Attribution
🤖 Generated with Claude Code
🤖 Co-authored by Claudius the Magnificent AI Agent
PR Hygiene ·
ca4d9d2.agents/skills/tenderdash-release/SKILL.md,AGENTS.md,CONTRIBUTING.mdand 6 more) — approved by lklimekWhen every merge requirement is met, the
PR Hygienecheck passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.