Repository navigation
feat(tokens): add guided token creation with complete review - #1176
Draft
Claudius-Maginificent wants to merge 13 commits into
Draft
Claudius-Maginificent wants to merge 13 commits into
Claudius-Maginificent wants to merge 13 commits into
Conversation
… to the Token Creator The Token Creator form survives navigation, and so did its copy of the selected identity. A key added on the identity's key screen never reached it, so Simple mode kept reporting that no eligible key exists. Arrival, refresh and identity cache updates now replace the creator's identity with the stored one. A selected key the identity no longer holds is dropped, and an identity that is no longer stored is deselected. The form inputs are kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Token Creator offers user identities that hold private keys, but it picked its starting identity from every stored identity. With a masternode or keyless identity selected, for example one stored before a wallet import, the selector showed "No identities found" next to a list of identities and Simple mode reported a missing key. The starting identity and the refreshed selection now come from the identities the creator offers. An identity it does not offer is deselected, so the selector picks one it does offer. A failed read of stored identities no longer drops the user's selection. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A failed registration was detected by matching banner text that no TaskError produces, so the creator stayed in its waiting state. The creator now sends the registration under its own dispatch context and leaves the wait in its error state, dropping the progress banner, when a failure arrives for that context. Failures of other tasks, and late failures from before a network switch, leave it alone. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Create Token (and Register Token Contract under Advanced) stayed enabled while a registration was waiting for its result, so creating and confirming again paid a second registration fee. Both buttons are now disabled while the creator waits, with a visible explanation, and are enabled again once the registration succeeds or fails. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…asks Clicking Confirm must send the registration and the balance refresh, each under a context of its own, and leave the creator waiting for the registration's context, so that only the registration's own failure ends the wait. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Introduce checked token amounts, explicit authority bundles, non-destructive examples, SDK-backed distribution previews, stable group references, absolute schedules, and safe document JSON preflight. Wire the seven-section workspace with contextual help and retain input independently of identity readiness. This checkpoint establishes the editor and model for the staged registration integration that follows. The disconnected legacy creator will be removed when its registration and routing tests move to the new lifecycle. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Codex gpt-6-astra <noreply@openai.com>
Prepare the exact owner-bound contract ID, validate current signing readiness, and sign only the reviewed payload. Persist public attempt metadata before sending and recover confirmation without another payment. Preserve confirmed outcomes when local saves fail. Also preserve inactive amount values across precision and example changes, synchronize schedule undo, and render approved help consequences. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Codex gpt-6-astra <noreply@openai.com>
Keep incomplete schedule input through template undo, report precise safe field corrections, and validate canonical keywords and document fee compatibility. Distinguish proven unsent requests from unknown outcomes, bind journal settlement to all public metadata, retain confirmed receipts and enforce the encoded request limit before sending. Keep summary and navigation visible, label form controls for accessibility, restore help focus, and remove the disconnected legacy creator. Migrate focused token navigation and routing coverage to the new workspace. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Codex gpt-6-astra <noreply@openai.com>
<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Claude gpt-6-astra <noreply@anthropic.com>
Keep policy choices visible beside the basic draft inputs. Prioritize actual changes in template comparisons while retaining every setting in the full wrapped comparison. Box large protocol causes without losing typed errors, and document no-funds and separately authorized live GUI scenarios. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Claude gpt-6-astra <noreply@anthropic.com>
Classify an edited example as custom when its supply or distribution settings change, while preserving authored data and permission-only SDK templates. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Claude gpt-6-astra <noreply@anthropic.com>
Keep the selected instant's UTC offset in custom date labels, including both occurrences of a repeated daylight-saving time. Preserve the allocation label when restoring schedule inputs, and wrap date controls in narrow editors. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Claude gpt-6-astra <noreply@anthropic.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Collaborator
|
🕓 Review not started yet because this PR is a draft.
Commit 02085bd. Normal review starts when eligible; priority review starts as soon as a slot is available. |
Restore the approved section headings, labels, examples and consequences. Keep protocol constraints and registration readiness truthful, and verify policy actions through scrolling. Document matched-state visual QA independently from functional checks. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Claude GPT-6 <noreply@anthropic.com>
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: Create a token through seven clear sections, understand the available powers, and check the exact settings before authorizing one creation.
User story
As a token creator, I want clear explanations and a complete review of my choices, so that I can create the intended token without overlooking an authority or paying for the same attempt twice.
Scenario
Base flow
Open Token Creator, name the token, compare a starting policy, configure supply and any advanced features, and proceed to Review. Choose an account and signing key, check the settings, then authorize creation separately.
Actual behavior
The Simple/Advanced split hides related controls. Amounts and future authorities are difficult to compare, confirmation omits much of the policy, and the creator must manually correlate a result with the token that was created.
Expected behavior
Detailed discussion
What was done
Design reference: interactive Token Creator proposal. The proposal uses illustrative account/fee/result data; production behavior is verified against the pinned source.
Testing
No live paid registration was executed. The committed GUI scenario separates the no-funds checks from its operator-only paid extension and records that remaining manual check explicitly. Automatic full Rust CI is suppressed while this PR is a draft.
Prior work
Depends on #1168; its identity refresh and request-routing/in-flight fixes are included rather than reimplemented. This PR targets
v1.0-devand does not merge the prerequisite into the base branch.🤖 Co-authored by Claudius the Magnificent AI Agent