Skip to content

fix(tokens): keep first token name button border visible - #1181

Merged
lklimek merged 1 commit into
v1.0-devfrom
fix/token-list-button-border
Nov 16, 2026
Merged

lklimek merged 1 commit into
v1.0-devfrom
fix/token-list-button-border

Conversation

@Claudius-Maginificent

@Claudius-Maginificent Claudius-Maginificent commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

TL;DR: Keep the complete outline around the first token name on My Tokens.

User story

As a token holder, I can read every token name as a consistently outlined button.

Scenario

Base flow

Open Tokens → My Tokens with several tracked tokens.

Actual behavior

The first name button loses its upper border. Other rows have complete outlines.

Expected behavior

Every name button has a complete outline and remains clickable.

Detailed discussion

Remove the negative vertical spacing that moves the first button above the table's clipping boundary. No global styling or row-height changes. This fix targets v1.0-dev independently of the Token Creator stack (#1176–#1179).

Testing

  • Regression reproduced before the fix, including dark/light themes, window widths, font sizes and scale factors; all eight variants pass after the fix.
  • Five focused tests pass, including name-button selection and the existing row-action tests. Scoped Clippy, formatting and diff checks pass.
  • Independent review has no findings.
  • Real desktop comparison also passes on the combined fix(tokens): retain the creator when opening a registered contract #1179 design plus this fix, using identical dark theme, 1260×780 window and scale. No payment operations.

Evidence and comparison images.

🤖 Co-authored by Claudius the Magnificent AI Agent

PR Hygiene · d3938d5

  • Bots — coderabbitai ✓ · thepastaclaw ✓
  • Self-review — not asked of a bot author
  • Build green
  • Approvals
    • files with no dedicated owner (src/ui/tokens/tokens_screen/my_tokens.rs) — approved by lklimek

When every merge requirement is met, the PR Hygiene check passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.

Summary by CodeRabbit

  • Bug Fixes
    • Improved token-list button border visibility and token-name selection across themes, window sizes, font scales, and display densities.
    • Verified that selecting a token requests pricing when no cached pricing data is available.

Keep token name buttons inside the table's paint clip. Cover all visible
rows in light and dark themes, larger text and pixel scales, and retain
the name-button selection action.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-Authored-By: Codex GPT-6 <noreply@openai.com>
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The token list removes a negative spacing adjustment before token-name buttons. Tests check button borders and alignment across themes and display configurations. They also check token selection and a pricing query when pricing data is not cached.

Changes: Token list layout and selection

Layer / File(s) Summary
Token-name button layout and behavior
src/ui/tokens/tokens_screen/my_tokens.rs
The token list removes the negative spacing adjustment before token-name buttons. New tests check button borders and alignment across themes, window sizes, font scales, and pixel densities. They also verify that selecting a token requests pricing when no pricing data is cached.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: pauldelucia

Merge Risk: Minimal · up to d3938

This is a small layout fix that keeps the first token name button's border visible on the My Tokens page. No concrete risk to token selection or other behavior was found, so it looks ready to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the actual change: it fixes the first token name button border on the My Tokens page so the border stays visible. The raw summary confirms removal of the negative ui.add_space(-1.0) …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the actual change: it fixes the first token name button border on the My Tokens page so the border stays visible. The raw summary confirms removal of the negative ui.add_space(-1.0) call before token-name buttons, plus tests covering border visibility and name-button selection. The title covers the primary change and omits the added tests, which is acceptable.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 32f8ede and d3938d5.

Files selected for processing: 1

  • src/ui/tokens/tokens_screen/my_tokens.rs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@thepastaclaw

thepastaclaw commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Final review complete — no blockers (commit d3938d5) · triage: low · Phase 2 only (no Phase 1 for this repository)

@lklimek
lklimek marked this pull request as ready for review November 16, 2026 14:53
@lklimek

lklimek commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

/skip-bots

@lklimek
lklimek enabled auto-merge (squash) November 16, 2026 14:53
@github-actions github-actions Bot added the bot-review-skipped A required review bot did not report; it was skipped by the window or by a person. label Nov 16, 2026

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final validation — Phase 2 only (no Phase 1 for this repository)

The PR is narrowly scoped to removing the negative spacing that clipped the first token-name button and adds focused regression coverage for themes, dimensions, font scales, pixel densities, clipping bounds, alignment, and selection behavior. The changed code preserves the existing click handler, and CI reports successful Clippy and Test Suite checks; only review and hygiene checks remain in progress. No in-scope correctness, architecture, security, or quality issues were found.

Review provenance

Source: reviewer 1: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: low by gpt-6.1-sol (effort low) — This is a small, self-contained UI fix in a single token-list screen that removes incorrect spacing without affecting critical surfaces or broader application behavior.
  • Phase 1 reviewers: not run (disabled for this repository)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort medium); agent phase2-reviewer, gpt-6.1-sol — rust-quality (completed, effort medium); agent phase2-reviewer

@github-actions github-actions Bot removed the bot-review-skipped A required review bot did not report; it was skipped by the window or by a person. label Nov 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Policy satisfied — this can merge.
Full checklist in the description.

@lklimek
lklimek merged commit e64f3e7 into v1.0-dev Nov 16, 2026
17 checks passed
@lklimek
lklimek deleted the fix/token-list-button-border branch November 16, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants