Repository navigation
fix(tokens): keep first token name button border visible - #1181
Conversation
Keep token name buttons inside the table's paint clip. Cover all visible rows in light and dark themes, larger text and pixel scales, and retain the name-button selection action. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Codex GPT-6 <noreply@openai.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
✅ Final review complete — no blockers (commit d3938d5) · triage: low · Phase 2 only (no Phase 1 for this repository) |
|
/skip-bots |
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — Phase 2 only (no Phase 1 for this repository)
The PR is narrowly scoped to removing the negative spacing that clipped the first token-name button and adds focused regression coverage for themes, dimensions, font scales, pixel densities, clipping bounds, alignment, and selection behavior. The changed code preserves the existing click handler, and CI reports successful Clippy and Test Suite checks; only review and hygiene checks remain in progress. No in-scope correctness, architecture, security, or quality issues were found.
Review provenance
Source: reviewer 1: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)
- Triage:
lowbygpt-6.1-sol(effort low) — This is a small, self-contained UI fix in a single token-list screen that removes incorrect spacing without affecting critical surfaces or broader application behavior. - Phase 1 reviewers: not run (disabled for this repository)
- Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-verifier - Phase 2 reviewers:
gpt-6.1-sol— general (completed, effort medium); agentphase2-reviewer,gpt-6.1-sol— rust-quality (completed, effort medium); agentphase2-reviewer
|
Policy satisfied — this can merge. |
TL;DR: Keep the complete outline around the first token name on My Tokens.
User story
As a token holder, I can read every token name as a consistently outlined button.
Scenario
Base flow
Open Tokens → My Tokens with several tracked tokens.
Actual behavior
The first name button loses its upper border. Other rows have complete outlines.
Expected behavior
Every name button has a complete outline and remains clickable.
Detailed discussion
Remove the negative vertical spacing that moves the first button above the table's clipping boundary. No global styling or row-height changes. This fix targets
v1.0-devindependently of the Token Creator stack (#1176–#1179).Testing
Evidence and comparison images.
🤖 Co-authored by Claudius the Magnificent AI Agent
PR Hygiene ·
d3938d5src/ui/tokens/tokens_screen/my_tokens.rs) — approved by lklimekWhen every merge requirement is met, the
PR Hygienecheck passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.Summary by CodeRabbit