Skip to content

feat(ui): align app-wide styles with the token proposal - #1177

Draft
Claudius-Maginificent wants to merge 7 commits into
feat/token-creator-workspacefrom
feat/app-design-system
Draft

Claudius-Maginificent wants to merge 7 commits into
feat/token-creator-workspacefrom
feat/app-design-system

Conversation

@Claudius-Maginificent

Copy link
Copy Markdown
Collaborator

TL;DR: Use the approved proposal’s readable type scale, palettes, spacing and controls throughout Dash Evo Tool.

User story

As a Dash Evo Tool user, I want consistent, readable forms and navigation across the application, so that moving between token creation, identities, wallets and settings feels familiar.

Scenario

Base flow

Open a token draft, enter its names, use contextual help, and switch to an identity form, wallet screen or settings. Choose a light or dark theme and resize the window.

Actual behavior

The token proposal and application use different typography, field sizes, surfaces and spacing. Several controls inherit small defaults, while local overrides make other screens inconsistent.

Expected behavior

Page titles, section headings, labels and hints have a clear shared hierarchy. Forms use readable fields and consistent controls in both themes, with navigation and actions reachable in a small window.

Detailed discussion

Design and scope

  • Shared design tokens and active component paths provide the native equivalent of a shared stylesheet: typography, text/accent/surface colors, spacing, shape and control metrics.
  • Existing bundled fonts provide a regular body face and actual semibold headings/buttons; no font or other binary assets are added.
  • Inputs keep their existing builder options, including masking, hints, focus, width and read-only behavior. Presentation changes do not alter signing, validation or payment behavior.
  • The token workspace uses the proposal’s heading hierarchy, cards and field grouping. Existing native navigation and truthful account/network state remain visible.

Approved reference: Token Creator proposal.

Stacking

This PR targets feat/token-creator-workspace and depends on #1176. The base PR owns token creation behavior and content. Merge that PR first, then retarget this PR to v1.0-dev; this PR must not duplicate the feature implementation in review.

Validation

  • Full GUI regression tier: 567/567 executed, zero skipped for the combined shared-style baseline (43e4e215, identical tested tree 8b42d2cf). The final muted-text/notice-role delta adds three real-render tests; 46/46 scoped tests passed on the final tree, including creator safeguards, small-window geometry and help focus.
  • Final-tree cargo fmt --all, format/diff checks, scoped all-feature binary + GUI-test clippy, and debug build passed. No source changes followed the verified build.
  • One independent Astra reviewer read all 107 changed files and the final nine-file delta, checked named test results, and inspected all 14 matched HTML/native pairs plus expanded, small-window and shared-screen evidence. No open findings in the reviewed scope.
  • Actual desktop QA used an empty isolated Testnet profile: both themes, client 1260×780, scale 1, the same fixed-supply draft and no selected issuer. Expanded allocations, group editing/removal, help/Escape, compare/keep/apply/undo, JSON validation/clear and confirmation/Cancel were exercised. Additional checks covered 800×600 and native X11 scale 1.25, wallet/import, identity/load and settings. No secrets or funds were used.
  • Matched comparison and explicit native adaptations. The app preserves its native shell, truthful network/readiness information, unit selectors and persistent scrolling workspace; this is not a pixel-identical copy of demo chrome. Gallery loading/navigation checks are separate from visual acceptance.
  • Draft PRs skip the repository’s automatic full Rust CI gate. The full workspace suite and paid/live-network registration were not run locally; visual coverage is the listed representative states, not every possible populated account state. The source-only payload scan found no credentials or binary assets.

🤖 Co-authored by Claudius the Magnificent AI Agent

lklimek and others added 7 commits November 12, 2026 14:49
Project the approved light and dark palette and typography into the global
egui style. Route UI text inputs through the shared builders and align cards,
navigation, dialogs and table rows with the same visual system.

Validation checkpoint: baseline regression tests reproduced typography,
contrast and control-height defects; formatting and diff checks pass.
Final combined-tree tests and visual review follow the content merge.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-Authored-By: Claude GPT-6 Astra <noreply@anthropic.com>
Preserve the reviewed wording and protocol corrections alongside the shared
page typography, context card and vertical name fields. Final validation
covers the combined tree.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-Authored-By: Claude GPT-6 <noreply@anthropic.com>
Use semantic foreground colors across app navigation, status text and identity components while preserving solid primary and danger fills. Keep the creator footer and useful editor area visible at minimum window sizes, stack compound amount controls in narrow columns, and align shared heading families.

Validate shared typography, target sizes, contrast, zoom preservation, all creator sections and expanded forms with 90 scoped tests. Preserve existing keyboard, modal and navigation behavior.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-Authored-By: Claude GPT-6 Astra <noreply@anthropic.com>
Make the Transfer form scroll so its action remains reachable at a
1050x700 viewport. Measure token layout against the rendered navigation
panel and scroll the Max Supply menu option before testing validation.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-Authored-By: Claude GPT-6 <noreply@anthropic.com>
Match subordinate headings, summary text and label rows to the approved design. Use accessible success and network toolbar foregrounds. Keep compact username actions, node picker footers and token transfer actions reachable with the shared control sizes.

Initialize isolated screen tests with the application font assets and theme, and scroll offscreen actions before checking their existing behavior. All 567 GUI tests and scoped clippy pass.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-Authored-By: Claude GPT-6 Astra <noreply@anthropic.com>
Preserve the transfer-scrolling and token-menu test fix author history.
The merged source tree is identical to the candidate validated by the
complete GUI test suite.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-Authored-By: Claude GPT-6 <noreply@anthropic.com>
Use shared muted body and hint renderers across the creator sections. Give contextual notices the approved surfaces, preserving warning severity and placing recurring authority before expanded fields and the empty-group notice after Add group.

Keep values, validation, registration behavior and user-facing wording intact. Three rendered role regressions, the 46-test affected scope and scoped clippy pass.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-Authored-By: Claude GPT-6 Astra <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@thepastaclaw

Copy link
Copy Markdown
Collaborator

🕓 Review not started yet because this PR is a draft.

  • Request normal review — click when the PR is ready for review.
  • Request priority review — click to move this review to the front of the queue.

Commit 9759930. Normal review starts when eligible; priority review starts as soon as a slot is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants