Repository navigation
fix: P0 console UX — access modes, enroll confirm, name/host/CIDR validation - #3
Merged
Merged
Conversation
Make visitor/spa/public first-class in the service list (badge, filter, empty-state copy), stop treating a closed public business port as a fault, require confirmation before issuing node credentials, and validate node names, target hosts, and CIDRs in the console and API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements only the four P0 console UX fixes. Does not change the gateway protocol or security model.
P0-1 — Access modes as first-class UI
P0-2 — Stop framing “no public port” as a fault
P0-3 — Confirm before issuing node credentials
P0-4 — Validate names / hostnames / CIDR
Files changed (why)
service-list.tsx,mappings-page.tsx,styles.css,messages.tsnodes-page.tsx,issued-dialog.tsx,messages.tsvalidate.ts,service.ts,service-editor.tsx,field.tsx,input.tsxvalidate.go,http.go,mutate.go,transfer.govalidate.test.ts,service.test.ts,validate_test.go,service_test.goHow verified
node --experimental-strip-types --testonsrc/lib/umbra/{validate,service}.test.tsand related domain tests (107 pass).go test ./internal/control/(includes new host/CIDR/name rejection cases).npx tsc --noEmit.umbrad+ Vite console):!!! bad/name?,not_a_host!!!,not-a-cidr, port99999blocked with inline errors; valid inputs and API rejects still work.Checklist