Repository navigation
fix: P1 console UX — settings, empty states, loading, public confirm - #4
Merged
Merged
Conversation
Rename System to Settings with a /settings route, make 2FA copy match what the page can do, unify empty states, keep loading distinct from empty, and require a second confirm before public access.
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #3 (P0 console UX). Branch is
fix/p1-console-uxfromfix/p0-console-ux. Merge after #3, or retarget tomainonce #3 lands.Summary
Implements only the four P1 console UX fixes. No protocol or security-model changes.
P1-1 — Settings, not System; 2FA copy matches reality
/settings;/deployredirects.P1-2 — Unified empty-state pattern
P1-3 — Loading ≠ empty
P1-4 — Confirm before Public access
Files changed (why)
routes/settings.tsx,routes/deploy.tsx,app-shell.tsx,quick-launcher.tsx,routeTree.gen.ts,umbra-ui-smoke.mjssystem-page.tsx,auth-panel.tsx,messages.tsempty-state.tsx, nodes/mappings/traffic/audit pages,rate-chart.tsxservice-editor.tsx,service.tsservice.test.ts,i18n.test.tsHow verified
needsPublicConfirm; i18nnav.settings; existing service tests still pass.npx tsc --noEmitand eslint on touched files./deploy→/settings; no bind-2FA CTA.AuthPanelis hidden when login is off).Checklist