Repository navigation
fix: console regressions after #5 — empty traffic, audit names, Quick Go, service name - #6
Merged
Merged
Conversation
…ce name rules Match traffic empty to the shared empty-state, prefer display names in audit objects, add 全部服务 to Quick Go, and reject invalid service names in the console and API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #5 (P2 console UX, which includes P0 #3 and P1 #4). Branch is
fix/p2-regression-console-uxfromfix/p2-console-ux.Summary
Fixes four regressions found after deploying the #5 stack. No protocol/security-model changes. No new P3 work.
F1 — Traffic empty state
观测 → 流量 with no data now uses the shared empty-state: Activity icon + 暂无流量 (compact). If there are no nodes, the CTA is 登记节点. Chart axes stay hidden.
F2 — Audit object column
Object column prefers a node/service display name. If live lookup is gone (e.g. after delete), it recovers the name from audit detail (
home-nas linux/amd64→home-nas). Raw ids stay as tooltip / fallback, never a blank cell.F3 — Quick Go 「全部服务」
Quick Go has an 全部服务 action (same wording as main nav) that opens
/mappings. Searching 全部服务 matches it; 添加服务 stays a separate action.F4 — Service name validation
Service names use the same character rules as node names.
!!!badshows an inline error and cannot advance; API create/update/import also reject it.工作室 SSHstill works.Files changed
empty-state.tsx,rate-chart.tsx,traffic-page.tsxlabels.ts,http.go,views.go,labels.test.ts,service_test.goquick-launcher.tsx,messages.ts,quick-launch.test.tsservice.ts,http.go,mutate.go,transfer.go,service.test.ts,service_test.goHow verified
home-nasovernde_abc; Quick Go query全部服务;validateService({ name: "!!!bad" })fails.go test ./internal/control/including delete-then-audittargetName=home-nasand mapping create!!!bad→ 400.npx tsc --noEmitand eslint on touched files.Checklist
!!!badcannot be saved