Skip to content

Small improvements to Image handling#13207

Merged
theimpulson merged 2 commits intoTeamNewPipe:devfrom
TobiGr:small-fixes
Mar 15, 2026
Merged

Small improvements to Image handling#13207
theimpulson merged 2 commits intoTeamNewPipe:devfrom
TobiGr:small-fixes

Conversation

@TobiGr
Copy link
Copy Markdown
Contributor

@TobiGr TobiGr commented Feb 7, 2026

What is it?

  • Bugfix (user facing)
  • Codebase improvement (dev facing)

Description of the changes in your PR

  • Use constants for unknown image dimensions in ImageStrategy.
  • Changes the order of image dimensions in the DescriptionFragement. width x height replaces height x width. width x height is usually used for digital images (e.g. see Wikipedia for PNG and in the graphics industry. height x width is used for frames and analog paintings as well as in data processing and machine learning contexts (numpy, ...). I think we should stick to the order that is commonly used for digital media. The underlying issue is that the Image class uses the wrong order in its constructor, too.

Before/After Screenshots/Screen Record

  • Before:
  • After:

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

height x width was used before which is an uncommon order.
@TobiGr TobiGr added bug Issue is related to a bug code quality Improvements to the codebase to improve the code quality labels Feb 7, 2026
@github-actions github-actions Bot added the size/small PRs with less than 50 changed lines label Feb 7, 2026
@TobiGr TobiGr changed the title Small fixes Small improvements to Image handling Feb 7, 2026
Copy link
Copy Markdown
Member

@theimpulson theimpulson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@theimpulson theimpulson merged commit 0d65733 into TeamNewPipe:dev Mar 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug code quality Improvements to the codebase to improve the code quality size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants