Skip to content

Small improvements to Image handling #13207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theimpulson merged 2 commits into from
Mar 15, 2026
+11 −3
Merged

Small improvements to Image handling #13207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6daf45
[DescriptionFragment] Fix thumbnail size: width x height
TobiGr Feb 6, 2026
e358867
Use dedicated constants for unknown image dimensions in ImageStrategy
TobiGr Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/src/main/java/org/schabi/newpipe/fragments/detail/BaseDescriptionFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,9 @@ protected void addImagesMetadataItem(final LayoutInflater inflater,
|| image.getWidth() != Image.WIDTH_UNKNOWN
// if even the resolution level is unknown, ?x? will be shown
|| image.getEstimatedResolutionLevel() == Image.ResolutionLevel.UNKNOWN) {
urls.append(imageSizeToText(image.getHeight()));
urls.append('x');
urls.append(imageSizeToText(image.getWidth()));
urls.append('x');
urls.append(imageSizeToText(image.getHeight()));
} else {
switch (image.getEstimatedResolutionLevel()) {
case LOW -> urls.append(getString(R.string.image_quality_low));
Expand Down
10 changes: 9 additions & 1 deletion app/src/main/java/org/schabi/newpipe/util/image/ImageStrategy.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,15 @@ object ImageStrategy {
fun dbUrlToImageList(url: String?): List<Image> {
return when (url) {
null -> listOf()
else -> listOf(Image(url, -1, -1, ResolutionLevel.UNKNOWN))

else -> listOf(
Image(
url,
Image.HEIGHT_UNKNOWN,
Image.WIDTH_UNKNOWN,
ResolutionLevel.UNKNOWN
)
)
}
}
}
Loading