Skip to content

Commit 0d65733

Browse files
authored
Merge pull request #13207 from TobiGr/small-fixes
Small improvements to Image handling
2 parents 9cc6f9f + e358867 commit 0d65733

2 files changed

Lines changed: 11 additions & 3 deletions

File tree

app/src/main/java/org/schabi/newpipe/fragments/detail/BaseDescriptionFragment.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -216,9 +216,9 @@ protected void addImagesMetadataItem(final LayoutInflater inflater,
216216
|| image.getWidth() != Image.WIDTH_UNKNOWN
217217
// if even the resolution level is unknown, ?x? will be shown
218218
|| image.getEstimatedResolutionLevel() == Image.ResolutionLevel.UNKNOWN) {
219-
urls.append(imageSizeToText(image.getHeight()));
220-
urls.append('x');
221219
urls.append(imageSizeToText(image.getWidth()));
220+
urls.append('x');
221+
urls.append(imageSizeToText(image.getHeight()));
222222
} else {
223223
switch (image.getEstimatedResolutionLevel()) {
224224
case LOW -> urls.append(getString(R.string.image_quality_low));

app/src/main/java/org/schabi/newpipe/util/image/ImageStrategy.kt

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,15 @@ object ImageStrategy {
186186
fun dbUrlToImageList(url: String?): List<Image> {
187187
return when (url) {
188188
null -> listOf()
189-
else -> listOf(Image(url, -1, -1, ResolutionLevel.UNKNOWN))
189+
190+
else -> listOf(
191+
Image(
192+
url,
193+
Image.HEIGHT_UNKNOWN,
194+
Image.WIDTH_UNKNOWN,
195+
ResolutionLevel.UNKNOWN
196+
)
197+
)
190198
}
191199
}
192200
}

0 commit comments

Comments
 (0)