Repository navigation
02: type-check web/ and hold the clean files clean - #12
Merged
Merged
Conversation
…pm so setup-node caches
Preact 11 gives a component no node of its own, so `this.base` was undefined and `measure()` never measured anything. The tile's element now comes in through a callback ref, so the measurement runs on the element it is meant to read. What this restores is the measurement, not a decision. `clipped` is false for every input, before and after the fix: the CSS removes the line clamp and lets the tile grow around its content on the only path that reads `clipped`, so no tile offers Allow for a command cut off by its edge today, and this fix does not start doing so.
The base branch carried three files Prettier would rewrite, so format:check failed on every run of this workflow: .ome/project.json, test/browser.test.ts and test/session-row-ui.test.ts. Whitespace only.
A browser closed just before the test's folder is removed can still be writing its profile, which left the folder non-empty and failed the run with ENOTEMPTY (run 38424667589, visible-models-ui). The removal now retries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The browser code gets type checking, and one real defect came out of it.
src/has strict type checking.web/did not. RunningcheckJsover it found 3,255 findings in 61 of its 63 files, and one of them is a bug. Fixing that bug removed two of the findings, and 3,253 remain.What changed
tsconfig.web.jsonandnpm run check:webtype-checkweb/**/*.jswith the same strict settings assrc/.scripts/check-web.mjsandscripts/web-clean.txtmake it a gate for the files that are already clean. It prints every finding and exits 1 only when a finding lands on a listed file, or when tsc could not run. 29 lines, no new dependency, no count baseline. A baseline is a number someone can raise by editing it.web/peeks.jsmeasured a peek tile againstthis.base, which Preact 11 never sets.measure()never measured, soclippedwas always false. The tile now gets its own element through a callback ref.npm run check:webin the same job as the other checks, as the step afternpm run check. Before this, the gate was decoration: nothing but a person running it by hand enforced it.Proof
node_modules/preact/dist/preact.mjs(the file served at/vendor/preact.mjs) has nobase. A run showedthis.base === undefinedat mount while the callback ref got the element.web/.web/peeks.jshas 109 of them, which is why it is not inscripts/web-clean.txt;web/sheets/shortcuts.jsandweb/themes.jsare clean and are.npm run checkexit 0,npm run lintexit 0,npm run format:checkclean,node --check web/peeks.jsok,node --test test/peeks-ui.test.ts22 pass.npm test630 pass, exit 0. The one flaky test this body used to name,test/visible-models-ui.test.ts, is deterministic with PR 01: CI runs the repo's checks on push and PR #11's one-line fix: 5 of 5 single-file runs pass.Open
web/index.html:26-38is browser code nothing checks. That needs its own ticket.clippedpath is unreachable.clippedis read only whenwholeOnTileis true, and on that path the CSS clamp is removed, so it is false for every input before and after this fix. No user-visible change here.test/peeks-ui.test.tsrecomputesclippedin the page and asserts the non-clipped case, so it cannot tell the fix from the defect. Making that state reachable is a layout change and needs its own ticket.Ticket 02. This run's report:
~/handoffs/oh-my-pocket/2026-10-13-pr11-13-rerun/implement-02-web-typecheck.md.