Repository navigation
docs: the router editor, the subagents chip, and the two new checks - #16
Merged
Merged
Conversation
The Features list gains a Routers bullet: the editor, a stage card's parts, the built-in Standard router, saved routers, the picker's Routers group, and Use in this session. The artifacts bullet gains the subagents chip and /subagents. "Building a router on it" now leads with the editor and reads the drop-ins as what they add beside it. The Development block lists check:web and coverage, which land in #12 and #13.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title:
docs: the router editor, the subagents chip, and the two new checksThe README predates the router editor (#7-#10): routers were still described as a drop-in
~/.pi-pocket/extensions/setup, and there was no router bullet in the Features list at all. Italso predates the subagents chip (#5). And its Development block lists the npm scripts, so it needs
the two scripts this flight adds.
What changed, in
README.mdonly:the stages, the rail's Routers button (Menu → Routers, the Routers place on a phone), a stage card
(its template, its words, the skills it reads first, its model, its effort), the built-in
Standard (Plan, Implement, Review, Fix, Ship), saved routers in
~/.pi-pocket/routers/<id>.json, the read-only From this machine routers, Use in thissession, the model picker's Routers group, and the session running on the router's model
until a plain model is picked.
/subagents: which models they may runon besides the session's own.
drop-ins read as what they add beside it. The four bullets and the
docs/extensions.mdlink areunchanged.
npm run check:web(02: type-check web/ and hold the clean files clean #12) andnpm run coverage(03: coverage floor and direct tests for the fence #13) afternpm test, and its comments are re-padded. Both scripts are in this flight and merge before thisPR, so the lines are true when it lands; they were read on their own branches before being named.
Every claim in the new text traces to the code:
web/routers.js(the editor's own labels),src/server/routers.ts(Standard, the saved-router path, detected routers),web/sheets/model.jsandweb/sheets/menu.js(the picker's Routers group, Menu → Routers),web/sheets/subagents.jsandweb/composer.js(the chip and its sheet), anddocs/features.md:57.Proof:
npm run lint→ exit 0.npx --no-install prettier --check README.md→ "All matched files use Prettier code style!".node --test test/docs-examples.test.ts→ 4 pass, 0 fail.npm run check→ exit 0.git diff --stat→README.md | 16 ++++++++++------, one file, 10 insertions, 6 deletions.npm test→ 630 tests, 627 pass, 3 fail, none of them this change's: one is thevisible-models-uirouter-row race 01: CI runs the repo's checks on push and PR #11 fixes, two are 10 s timeouts intest/subagent-policy.test.tsthat pass on their own (load on the dev machine).Open items:
npm run format:checkfails on the base branch (4433a47) over.ome/project.json,test/browser.test.tsandtest/session-row-ui.test.ts. This PR does not touch them; 01: CI runs the repo's checks on push and PR #11'schore(01): format the three files CI's format:check caughtfixes them, and 01: CI runs the repo's checks on push and PR #11 merges first.If that commit is dropped from 01: CI runs the repo's checks on push and PR #11, this failure comes back on every branch of the flight.
dispatcher-only router, extra words for the router). The Features bullet keeps to the parts a
reader needs;
docs/features.md:57is the full tour.TannerMidd/pi-pocket, the upstream, on the fork'sREADME. Left alone: it is a separate change and not part of this review.