Repository navigation
Clean up release/0.5.0 (screenshot size contract, README, displayUrl mirrors) - #14
Conversation
|
Review findings (two rounds, final verdict: clean). First review:
Fix round: the viewport branch of screenshot() now reports Math.round(view.clientWidth/clientHeight) as the size (the scale term is unchanged), the doc comment says the reported size is the page's CSS size at capture, and a new test pins the contract (red before the fix at 1265 vs 1280, green after). Re-review: clean. The fix matches the plan's Branch B exactly, the fullPage branch and viewport application are untouched, and the two updated assertions (1280 to 1265) expect the true scrollbar-affected width with the scale assertions still pinning the contract. Non-blocking observation for a follow-up: on the DPR-2 presets (mobile, tablet) the bare fit scale term omits the 1/DPR clip factor, so the bitmap-vs-reported contract is off by the DPR factor there. It is pre-existing on the base commit and outside this change. Run folder: ~/handoffs/oh-my-pocket/2026-10-13-pr11-13-cleanup |
|
Retargeted from main (a stale mirror of upstream 0.13.0) to oh-my-pocket, the fork's default branch. Merged origin/oh-my-pocket in; no force push. check and lint pass. npm test: 628 pass, 1 fail in test/visible-models-ui.test.ts ("the owner's switches decide which models the model menu offers"), which is flaky on this code (passed then failed on rerun) and outside this diff. |
Follow-up cleanup for the merged release/0.5.0 (PR #12), from the 2026-10-13 review of PRs #11 to #13.
Changes:
Proof: node --test test/browser.test.ts 10/10, npm run check and npm run lint clean, npm test 461/461.
Review: two rounds. The first review caught the scrollbar break in the size contract (the initial no-op verdict was wrong) and showed that two full-suite test failures are load sensitive flakes that pass in isolation and at the base commit, not a regression. The fix round and re-review closed both findings. Final verdict: clean.
Run folder: ~/handoffs/oh-my-pocket/2026-10-13-pr11-13-cleanup (review.md, plan.md, pr12-fix.md, rereview-pr12.md).