Skip to content

fix(components-map): declare @swr-data-lab/components as peer dependency - #554

Merged
romanlamsal merged 1 commit into
mainfrom
fix/components-map-peer-dep
Sep 30, 2026
Merged

romanlamsal merged 1 commit into
mainfrom
fix/components-map-peer-dep

Conversation

@romanlamsal

Copy link
Copy Markdown
Contributor

components-map/dist imports @swr-data-lab/components in 19 modules, but the package only listed it as a devDependency ("*", for the workspace link). Consumers installing @swr-data-lab/components-map on its own would get unresolved imports. publint doesn't catch this.

This adds "@swr-data-lab/components": "^4.0.0" to peerDependencies. The devDependency stays so the workspace link keeps working locally; npm still resolves it to ./components (the in-repo version field is stale at 1.0.6 because semantic-release sets the real version only at publish time).

Merging this triggers release-components-map.yml, which should publish the first real release (1.0.0) now that the package exists on npm and its trusted publisher is configured.

Verified locally: clean npm ci, npm run package -w components-map (publint: all good), npm pack --dry-run.

🤖 Generated with Claude Code

19 modules in components-map/dist import @swr-data-lab/components, but it
was only a devDependency ("*" for the workspace link), so installing
@swr-data-lab/components-map alone left those imports unresolved.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@romanlamsal
romanlamsal merged commit a6c6fab into main Sep 30, 2026
2 checks passed
@romanlamsal
romanlamsal deleted the fix/components-map-peer-dep branch September 30, 2026 20:47
romanlamsal added a commit that referenced this pull request Sep 30, 2026
semantic-release analyzed every commit since a package's last tag,
regardless of which files it touched. The components-map fix in #554
therefore also released @swr-data-lab/components@4.0.1 when #555
triggered the components workflow.

Both packages now extend semantic-release-monorepo, which limits
analyzeCommits and generateNotes to commits that changed files inside
the package folder. The explicit tagFormat keeps the existing
components-v* / components-map-v* tags (the plugin's default would be
@swr-data-lab/<pkg>-v*).

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant