Skip to content

Declare @swr-data-lab/components as a peer dependency of components-map #559

Description

@romanlamsal

What

Declare @swr-data-lab/components as a peer dependency (^4.0.0) of @swr-data-lab/components-map. The "*" devDependency stays, for the workspace link.

Why

19 modules in components-map/dist import @swr-data-lab/components, but it was only listed as a devDependency. Installing components-map on its own left those imports unresolved. publint doesn't catch this.

^4.0.0 works alongside the workspace link even though components/package.json says 1.0.6 (semantic-release sets the real version only at publish time): npm still resolves it to ./components, with no extra registry copy.

Merging this produced the first real release, @swr-data-lab/components-map@1.0.0 (tag components-map-v1.0.0), with the peer dependency in the published manifest.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions