Skip to content

Remove legacy release.yml after moving trusted publishing #560

Description

@romanlamsal

What

  • Deleted .github/workflows/release.yml.
  • release-components.yml now also triggers on changes to itself (.github/workflows/release-components.yml in its paths).

Why

release.yml only existed because npm trusted publishing for @swr-data-lab/components was bound to that filename (see its TODO). With the publisher moved to release-components.yml, the old workflow would have failed on every components/** push. The self-trigger makes workflow edits run on merge.

Known trade-off

The merge ran release components, which published @swr-data-lab/components@4.0.1 (tag components-v4.0.1) with no changes to components: https://github.com/SWRdata/components/actions/runs/36775958165

semantic-release counted the fix(components-map): … commit from #554 toward components, because it analyzes every commit since the last tag regardless of path. Fixed going forward in #561.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions