Skip to content

[Chore] Align main runtime tests with shipped Kimi models - #3609

Open
roomote-roomote[bot] wants to merge 1 commit into
mainfrom
fix/main-kimi-runtime-assertions
Open

roomote-roomote[bot] wants to merge 1 commit into
mainfrom
fix/main-kimi-runtime-assertions

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

​Opened on behalf of Matt Rubens. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

Related issue

Follow-up to promotion #3598 and the existing develop repair #3603; no separate issue.

Why this PR exists

  • A maintainer explicitly invited this PR in the linked issue or discussion
  • I am a maintainer / this is internal Roomote work

What changed

Apply the exact four-line test correction from #3603 to a branch based on main 01f01c978d9cbec04d8dac164608daa048c090c9. Both exhaustive Kimi for Coding model-list assertions now include the shipped k3.1-pro and k3.1-pro-highspeed routes. The expectations remain exhaustive; provider behavior is unchanged.

The v1.19.4 promotion merged before the develop test correction reached main. Main's CI Test failure confirms the stale worker assertion. Develop already contains the same repair in 71ee50ca65777fb1669a837d019384dbd9be9e44; this PR imports no other develop changes.

Release publication is independent of this repair: v1.19.4 was published at 2026-10-27 13:56:29 UTC by the successful tag-triggered image/release workflow. With the root version unchanged and its tag already present, merging this PR does not create another product release. A main push still triggers normal main-channel image publication and its configured production notification, as defined in .github/workflows/publish-ghcr.yml.

How it was tested

  • Main-based repair: pnpm exec dotenvx run -f .env.test -- pnpm --filter @roomote/cloud-agents exec vitest run src/server/__tests__/opencode-runtime.test.ts — 46 passed.
  • Main-based repair: pnpm exec dotenvx run -f .env.test -- pnpm --filter @roomote/worker exec vitest run src/run-task/agent-home.test.ts — 117 passed.
  • git diff --check and targeted pnpm exec oxfmt --check — passed.
  • Normal pre-push gates — oxlint, residual ESLint, check-types:fast, and Knip passed. Turbo reused local lint/typecheck results for the same source/test inputs validated earlier in this task.
  • Local commit-time Judgement was incomplete for evidence collection on three criteria; it is not a successful judgment and needs a completed check before merge. Hooks were not bypassed.
  • Browser proof is not applicable to four assertion-only additions. Full repository tests were not rerun locally; fresh hosted CI remains required.

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally (normal lint:fast / check-types:fast pre-push equivalents passed)
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset (test-only correction; no release-note change)

@roomote-community

roomote-community Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

No code issues found. Both exhaustive model-list assertions match the shared Kimi provider registration, including k3.1-pro and k3.1-pro-highspeed. Current-head lint and Knip passed; tests and other CI checks were still pending when inspected. See session

Reviewed 62b3fde

@roomote-roomote
roomote-roomote Bot marked this pull request as ready for review October 27, 2026 14:05

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant